minor #16085 [Debug] Deprecate providing $fileLinkFormat as second argument (nicolas-grekas)

fabpot · fabpot · commit 6acd43d45f3b · 2015-10-02T19:35:32.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [Debug] Deprecate providing $fileLinkFormat as second argument | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- ed3611d [Debug] Deprecate providing $fileLinkFormat as second argument
diff --git a/src/Symfony/Component/Debug/ExceptionHandler.php b/src/Symfony/Component/Debug/ExceptionHandler.php
@@ -39,6 +39,8 @@ class ExceptionHandler
     public function __construct($debug = true, $charset = null, $fileLinkFormat = null)
     {
         if (false !== strpos($charset, '%')) {
+            @trigger_error('Providing $fileLinkFormat as second argument to '.__METHOD__.' is deprecated since version 2.8 and will be unsupported in 3.0. Please provide it as third argument, after $charset.', E_USER_DEPRECATED);
+
             // Swap $charset and $fileLinkFormat for BC reasons
             $pivot = $fileLinkFormat;
             $fileLinkFormat = $charset;

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,8 @@ class ExceptionHandler`
`39`	`39`	`public function __construct($debug = true, $charset = null, $fileLinkFormat = null)`
`40`	`40`	`{`
`41`	`41`	`if (false !== strpos($charset, '%')) {`
	`42`	`+ @trigger_error('Providing $fileLinkFormat as second argument to '.__METHOD__.' is deprecated since version 2.8 and will be unsupported in 3.0. Please provide it as third argument, after $charset.', E_USER_DEPRECATED);`
	`43`	`+`
`42`	`44`	`// Swap $charset and $fileLinkFormat for BC reasons`
`43`	`45`	`$pivot = $fileLinkFormat;`
`44`	`46`	`$fileLinkFormat = $charset;`