bug #47019 [Console] Fix comparison with completion api version (GromNaN)

fabpot · fabpot · commit 6babf863c6d6 · 2022-07-22T15:03:15.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Console] Fix comparison with completion api version | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46901 | License | MIT | Doc PR | n/a Comparison introduced in #46901 is wrong. Commits ------- 91c8c83 Fix comparison with completion api version
diff --git a/src/Symfony/Component/Console/Command/CompleteCommand.php b/src/Symfony/Component/Console/Command/CompleteCommand.php
@@ -82,7 +82,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         try {
             // "symfony" must be kept for compat with the shell scripts generated by Symfony Console 5.4 - 6.1
             $version = $input->getOption('symfony') ? '1' : $input->getOption('api-version');
-            if ($version && version_compare($version, self::COMPLETION_API_VERSION, '>=')) {
+            if ($version && version_compare($version, self::COMPLETION_API_VERSION, '<')) {
                 $message = sprintf('Completion script version is not supported ("%s" given, ">=%s" required).', $version, self::COMPLETION_API_VERSION);
                 $this->log($message);
 
diff --git a/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php b/src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php
@@ -128,7 +128,7 @@ public function provideCompleteCommandInputDefinitionInputs()
     private function execute(array $input)
     {
         // run in verbose mode to assert exceptions
-        $this->tester->execute($input ? ($input + ['--shell' => 'bash']) : $input, ['verbosity' => OutputInterface::VERBOSITY_DEBUG]);
+        $this->tester->execute($input ? ($input + ['--shell' => 'bash', '--api-version' => CompleteCommand::COMPLETION_API_VERSION]) : $input, ['verbosity' => OutputInterface::VERBOSITY_DEBUG]);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function provideCompleteCommandInputDefinitionInputs()`
`128`	`128`	`private function execute(array $input)`
`129`	`129`	`{`
`130`	`130`	`// run in verbose mode to assert exceptions`
`131`		`- $this->tester->execute($input ? ($input + ['--shell' => 'bash']) : $input, ['verbosity' => OutputInterface::VERBOSITY_DEBUG]);`
	`131`	`+ $this->tester->execute($input ? ($input + ['--shell' => 'bash', '--api-version' => CompleteCommand::COMPLETION_API_VERSION]) : $input, ['verbosity' => OutputInterface::VERBOSITY_DEBUG]);`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`