Fix typo and use assertSame instead of assertEquals

fabricecw · fabricecw · commit 6d87ad5149e4 · 2023-10-12T10:25:48.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php b/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php
@@ -106,15 +106,15 @@ public function testGetExpiresTime()
     {
         $cookie = Cookie::create('foo', 'bar');
 
-        $this->assertEquals(0, $cookie->getExpiresTime(), '->getExpiresTime() returns the default expire date');
+        $this->assertSame(0, $cookie->getExpiresTime(), '->getExpiresTime() returns the default expire date');
 
         $cookie = Cookie::create('foo', 'bar', $expire = time() + 3600);
 
-        $this->assertEquals($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');
+        $this->assertSame($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');
 
         $cookie = Cookie::create('foo')->withExpires($expire = time() + 3600);
 
-        $this->assertEquals($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');
+        $this->assertSame($expire, $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');
     }
 
     public function testConstructorWithDateTime()
@@ -158,11 +158,11 @@ public function testGetDomain()
     {
         $cookie = Cookie::create('foo', 'bar', 0, '/', '.myfoodomain.com');
 
-        $this->assertEquals('.myfoodomain.com', $cookie->getDomain(), '->getDomain() returns the domain name on which the cookie is valid');
+        $this->assertSame('.myfoodomain.com', $cookie->getDomain(), '->getDomain() returns the domain name on which the cookie is valid');
 
         $cookie = Cookie::create('foo')->withDomain('.mybardomain.com');
 
-        $this->assertEquals('.mybardomain.com', $cookie->getDomain(), '->getDomain() returns the domain name on which the cookie is valid');
+        $this->assertSame('.mybardomain.com', $cookie->getDomain(), '->getDomain() returns the domain name on which the cookie is valid');
     }
 
     public function testIsSecure()
@@ -191,7 +191,7 @@ public function testIsPartitioned()
     {
         $cookie = Cookie::create('foo', 'bar', 0, '/', '.myfoodomain.com', true, true,false, 'Lax', true);
 
-        $this->assertTrue($cookie->isPartitioned(),);
+        $this->assertTrue($cookie->isPartitioned());
 
         $cookie = Cookie::create('foo')->withPartitioned(true);
 
@@ -240,42 +240,42 @@ public function testToString()
     {
         $expected = 'foo=bar; expires=Fri, 20 May 2011 15:25:52 GMT; Max-Age=0; path=/; domain=.myfoodomain.com; secure; httponly';
         $cookie = Cookie::create('foo', 'bar', $expire = strtotime('Fri, 20 May 2011 15:25:52 GMT'), '/', '.myfoodomain.com', true, true, false, null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of the cookie');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of the cookie');
 
         $cookie = Cookie::create('foo')
             ->withValue('bar')
             ->withExpires(strtotime('Fri, 20 May 2011 15:25:52 GMT'))
             ->withDomain('.myfoodomain.com')
             ->withSecure(true)
             ->withSameSite(null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of the cookie');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of the cookie');
 
         $expected = 'foo=bar%20with%20white%20spaces; expires=Fri, 20 May 2011 15:25:52 GMT; Max-Age=0; path=/; domain=.myfoodomain.com; secure; httponly';
         $cookie = Cookie::create('foo', 'bar with white spaces', strtotime('Fri, 20 May 2011 15:25:52 GMT'), '/', '.myfoodomain.com', true, true, false, null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() encodes the value of the cookie according to RFC 3986 (white space = %20)');
+        $this->assertSame($expected, (string) $cookie, '->__toString() encodes the value of the cookie according to RFC 3986 (white space = %20)');
 
         $cookie = Cookie::create('foo')
             ->withValue('bar with white spaces')
             ->withExpires(strtotime('Fri, 20 May 2011 15:25:52 GMT'))
             ->withDomain('.myfoodomain.com')
             ->withSecure(true)
             ->withSameSite(null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() encodes the value of the cookie according to RFC 3986 (white space = %20)');
+        $this->assertSame($expected, (string) $cookie, '->__toString() encodes the value of the cookie according to RFC 3986 (white space = %20)');
 
         $expected = 'foo=deleted; expires='.gmdate('D, d M Y H:i:s T', $expire = time() - 31536001).'; Max-Age=0; path=/admin/; domain=.myfoodomain.com; httponly';
         $cookie = Cookie::create('foo', null, 1, '/admin/', '.myfoodomain.com', false, true, false, null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
 
         $cookie = Cookie::create('foo')
             ->withExpires(1)
             ->withPath('/admin/')
             ->withDomain('.myfoodomain.com')
             ->withSameSite(null);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
 
         $expected = 'foo=deleted; expires='.gmdate('D, d M Y H:i:s T', $expire = time() - 31536001).'; Max-Age=0; path=/admin/; domain=.myfoodomain.com; secure; httponly; samesite=none; partitioned';
         $cookie = Cookie::create('foo', null, 1, '/admin/', '.myfoodomain.com', true, true, false, 'none', true);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
 
         $cookie = Cookie::create('foo')
             ->withExpires(1)
@@ -285,49 +285,49 @@ public function testToString()
             ->withHttpOnly(true)
             ->withSameSite('none')
             ->withPartitioned(true);
-        $this->assertEquals($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
+        $this->assertSame($expected, (string) $cookie, '->__toString() returns string representation of a cleared cookie if value is NULL');
 
         $expected = 'foo=bar; path=/; httponly; samesite=lax';
         $cookie = Cookie::create('foo', 'bar');
-        $this->assertEquals($expected, (string) $cookie);
+        $this->assertSame($expected, (string) $cookie);
 
         $cookie = Cookie::create('foo')->withValue('bar');
-        $this->assertEquals($expected, (string) $cookie);
+        $this->assertSame($expected, (string) $cookie);
     }
 
     public function testRawCookie()
     {
         $cookie = Cookie::create('foo', 'b a r', 0, '/', null, false, false, false, null);
         $this->assertFalse($cookie->isRaw());
-        $this->assertEquals('foo=b%20a%20r; path=/', (string) $cookie);
+        $this->assertSame('foo=b%20a%20r; path=/', (string) $cookie);
 
         $cookie = Cookie::create('test')->withValue('t e s t')->withHttpOnly(false)->withSameSite(null);
         $this->assertFalse($cookie->isRaw());
-        $this->assertEquals('test=t%20e%20s%20t; path=/', (string) $cookie);
+        $this->assertSame('test=t%20e%20s%20t; path=/', (string) $cookie);
 
         $cookie = Cookie::create('foo', 'b+a+r', 0, '/', null, false, false, true, null);
         $this->assertTrue($cookie->isRaw());
-        $this->assertEquals('foo=b+a+r; path=/', (string) $cookie);
+        $this->assertSame('foo=b+a+r; path=/', (string) $cookie);
 
         $cookie = Cookie::create('foo')
             ->withValue('t+e+s+t')
             ->withHttpOnly(false)
             ->withRaw(true)
             ->withSameSite(null);
         $this->assertTrue($cookie->isRaw());
-        $this->assertEquals('foo=t+e+s+t; path=/', (string) $cookie);
+        $this->assertSame('foo=t+e+s+t; path=/', (string) $cookie);
     }
 
     public function testGetMaxAge()
     {
         $cookie = Cookie::create('foo', 'bar');
-        $this->assertEquals(0, $cookie->getMaxAge());
+        $this->assertSame(0, $cookie->getMaxAge());
 
         $cookie = Cookie::create('foo', 'bar', $expire = time() + 100);
-        $this->assertEquals($expire - time(), $cookie->getMaxAge());
+        $this->assertSame($expire - time(), $cookie->getMaxAge());
 
         $cookie = Cookie::create('foo', 'bar', $expire = time() - 100);
-        $this->assertEquals(0, $cookie->getMaxAge());
+        $this->assertSame(0, $cookie->getMaxAge());
     }
 
     public function testFromString()
@@ -363,13 +363,13 @@ public function testFromStringWithHttpOnly()
     public function testSameSiteAttribute()
     {
         $cookie = new Cookie('foo', 'bar', 0, '/', null, false, true, false, 'Lax');
-        $this->assertEquals('lax', $cookie->getSameSite());
+        $this->assertSame('lax', $cookie->getSameSite());
 
         $cookie = new Cookie('foo', 'bar', 0, '/', null, false, true, false, '');
         $this->assertNull($cookie->getSameSite());
 
         $cookie = Cookie::create('foo')->withSameSite('Lax');
-        $this->assertEquals('lax', $cookie->getSameSite());
+        $this->assertSame('lax', $cookie->getSameSite());
     }
 
     public function testSetSecureDefault()
@@ -392,27 +392,27 @@ public function testMaxAge()
         $futureDateOneHour = gmdate('D, d M Y H:i:s T', time() + 3600);
 
         $cookie = Cookie::fromString('foo=bar; Max-Age=3600; path=/');
-        $this->assertEquals('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
+        $this->assertSame('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
 
         $cookie = Cookie::fromString('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/');
-        $this->assertEquals('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
+        $this->assertSame('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
 
         $futureDateHalfHour = gmdate('D, d M Y H:i:s T', time() + 1800);
 
         // Max-Age value takes precedence before expires
         $cookie = Cookie::fromString('foo=bar; expires='.$futureDateHalfHour.'; Max-Age=3600; path=/');
-        $this->assertEquals('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
+        $this->assertSame('foo=bar; expires='.$futureDateOneHour.'; Max-Age=3600; path=/', $cookie->__toString());
     }
 
     public function testExpiredWithMaxAge()
     {
         $cookie = Cookie::fromString('foo=bar; expires=Fri, 20 May 2011 15:25:52 GMT; Max-Age=0; path=/');
-        $this->assertEquals('foo=bar; expires=Fri, 20 May 2011 15:25:52 GMT; Max-Age=0; path=/', $cookie->__toString());
+        $this->assertSame('foo=bar; expires=Fri, 20 May 2011 15:25:52 GMT; Max-Age=0; path=/', $cookie->__toString());
 
         $futureDate = gmdate('D, d-M-Y H:i:s T', time() + 864000);
 
         $cookie = Cookie::fromString('foo=bar; expires='.$futureDate.'; Max-Age=0; path=/');
-        $this->assertEquals(time(), $cookie->getExpiresTime());
-        $this->assertEquals('foo=bar; expires='.gmdate('D, d M Y H:i:s T', $cookie->getExpiresTime()).'; Max-Age=0; path=/', $cookie->__toString());
+        $this->assertSame(time(), $cookie->getExpiresTime());
+        $this->assertSame('foo=bar; expires='.gmdate('D, d M Y H:i:s T', $cookie->getExpiresTime()).'; Max-Age=0; path=/', $cookie->__toString());
     }
 }
