[HttpFoundation][FrameworkBundle] Reset Request's formats using the service resetter

nicolas-grekas · nicolas-grekas · commit 78ab09655051 · 2025-01-07T19:12:25.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.php
@@ -100,6 +100,7 @@ class_exists(WorkflowEvents::class) ? WorkflowEvents::ALIASES : []
         ->alias(HttpKernelInterface::class, 'http_kernel')
 
         ->set('request_stack', RequestStack::class)
+            ->tag('kernel.reset', ['method' => 'resetRequestFormats', 'on_invalid' => 'ignore'])
             ->public()
         ->alias(RequestStack::class, 'request_stack')
 
diff --git a/src/Symfony/Component/HttpFoundation/RequestStack.php b/src/Symfony/Component/HttpFoundation/RequestStack.php
@@ -106,4 +106,11 @@ public function getSession(): SessionInterface
 
         throw new SessionNotFoundException();
     }
+
+    public function resetRequestFormats(): void
+    {
+        static $resetRequestFormats;
+        $resetRequestFormats ??= \Closure::bind(static fn () => self::$formats = null, null, Request::class);
+        $resetRequestFormats();
+    }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestStackTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestStackTest.php
@@ -67,4 +67,18 @@ public function testGetParentRequest()
         $requestStack->push($secondSubRequest);
         $this->assertSame($firstSubRequest, $requestStack->getParentRequest());
     }
+
+    public function testResetRequestFormats()
+    {
+        $requestStack = new RequestStack();
+
+        $request = Request::create('/foo');
+        $request->setFormat('foo', ['application/foo']);
+
+        $this->assertSame(['application/foo'], $request->getMimeTypes('foo'));
+
+        $requestStack->resetRequestFormats();
+
+        $this->assertSame([], $request->getMimeTypes('foo'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -106,4 +106,11 @@ public function getSession(): SessionInterface`
`106`	`106`
`107`	`107`	`throw new SessionNotFoundException();`
`108`	`108`	`}`
	`109`	`+`
	`110`	`+ public function resetRequestFormats(): void`
	`111`	`+ {`
	`112`	`+ static $resetRequestFormats;`
	`113`	`+ $resetRequestFormats ??= \Closure::bind(static fn () => self::$formats = null, null, Request::class);`
	`114`	`+ $resetRequestFormats();`
	`115`	`+ }`
`109`	`116`	`}`