[Console] Add proper return type-hint to Command::execute() method in all core Commands

jschaedl · jschaedl · commit 78d7da22e1a8 · 2019-10-01T12:23:45.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php
@@ -54,7 +54,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
@@ -72,7 +72,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $fs = $this->filesystem;
         $io = new SymfonyStyle($input, $output);
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php
@@ -60,7 +60,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
         $kernel = $this->getApplication()->getKernel();
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolDeleteCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolDeleteCommand.php
@@ -59,7 +59,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
         $pool = $input->getArgument('pool');
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolListCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolListCommand.php
@@ -51,7 +51,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolPruneCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CachePoolPruneCommand.php
@@ -57,7 +57,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php
@@ -66,7 +66,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php
@@ -63,7 +63,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
         $errorIo = $io->getErrorStyle();
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
@@ -114,7 +114,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         if ($input->getOption('show-private')) {
             @trigger_error('The "--show-private" option no longer has any effect and is deprecated since Symfony 4.1.', E_USER_DEPRECATED);
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/EventDispatcherDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/EventDispatcherDebugCommand.php
@@ -69,7 +69,7 @@ protected function configure()
      *
      * @throws \LogicException
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php
@@ -73,7 +73,7 @@ protected function configure()
      *
      * @throws InvalidArgumentException When route does not exist
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
         $name = $input->getArgument('name');
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
@@ -124,7 +124,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php
@@ -59,7 +59,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $container = $this->getApplication()->getKernel()->getContainer();
         $serviceId = $input->getArgument('name');
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -254,7 +254,7 @@ public function run(InputInterface $input, OutputInterface $output)
         } else {
             $statusCode = $this->execute($input, $output);
 
-            if (!is_int($statusCode)) {
+            if (!\is_int($statusCode)) {
                 @trigger_error(sprintf('A non numeric or nullable $statusCode returned by Command::execute() is deprecated since Symfony 4.4, return an integer value instead.'), E_USER_DEPRECATED);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ protected function configure()`
`54`	`54`	`/**`
`55`	`55`	`* {@inheritdoc}`
`56`	`56`	`*/`
`57`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`57`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`58`	`58`	`{`
`59`	`59`	`$io = new SymfonyStyle($input, $output);`
`60`	`60`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ protected function configure()`
`72`	`72`	`/**`
`73`	`73`	`* {@inheritdoc}`
`74`	`74`	`*/`
`75`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`75`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`76`	`76`	`{`
`77`	`77`	`$fs = $this->filesystem;`
`78`	`78`	`$io = new SymfonyStyle($input, $output);`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected function configure()`
`60`	`60`	`/**`
`61`	`61`	`* {@inheritdoc}`
`62`	`62`	`*/`
`63`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`63`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`64`	`64`	`{`
`65`	`65`	`$io = new SymfonyStyle($input, $output);`
`66`	`66`	`$kernel = $this->getApplication()->getKernel();`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ protected function configure()`
`59`	`59`	`/**`
`60`	`60`	`* {@inheritdoc}`
`61`	`61`	`*/`
`62`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`62`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`63`	`63`	`{`
`64`	`64`	`$io = new SymfonyStyle($input, $output);`
`65`	`65`	`$pool = $input->getArgument('pool');`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ protected function configure()`
`51`	`51`	`/**`
`52`	`52`	`* {@inheritdoc}`
`53`	`53`	`*/`
`54`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`54`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`55`	`55`	`{`
`56`	`56`	`$io = new SymfonyStyle($input, $output);`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ protected function configure()`
`57`	`57`	`/**`
`58`	`58`	`* {@inheritdoc}`
`59`	`59`	`*/`
`60`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`60`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`61`	`61`	`{`
`62`	`62`	`$io = new SymfonyStyle($input, $output);`
`63`	`63`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ protected function configure()`
`66`	`66`	`/**`
`67`	`67`	`* {@inheritdoc}`
`68`	`68`	`*/`
`69`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`69`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`70`	`70`	`{`
`71`	`71`	`$io = new SymfonyStyle($input, $output);`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ protected function configure()`
`63`	`63`	`/**`
`64`	`64`	`* {@inheritdoc}`
`65`	`65`	`*/`
`66`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`66`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`67`	`67`	`{`
`68`	`68`	`$io = new SymfonyStyle($input, $output);`
`69`	`69`	`$errorIo = $io->getErrorStyle();`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ protected function configure()`
`114`	`114`	`/**`
`115`	`115`	`* {@inheritdoc}`
`116`	`116`	`*/`
`117`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`117`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`118`	`118`	`{`
`119`	`119`	`if ($input->getOption('show-private')) {`
`120`	`120`	`@trigger_error('The "--show-private" option no longer has any effect and is deprecated since Symfony 4.1.', E_USER_DEPRECATED);`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ protected function configure()`
`69`	`69`	`*`
`70`	`70`	`* @throws \LogicException`
`71`	`71`	`*/`
`72`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`72`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`73`	`73`	`{`
`74`	`74`	`$io = new SymfonyStyle($input, $output);`
`75`	`75`