fix(property-info): make sure that SerializerExtractor returns null for invalid class metadata

wuchen90 · wuchen90 · commit 7bc832e29c96 · 2025-01-07T10:09:35.000+01:00
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/SerializerExtractor.php
@@ -34,7 +34,7 @@ public function getProperties(string $class, array $context = []): ?array
             return null;
         }
 
-        if (!$this->classMetadataFactory->getMetadataFor($class)) {
+        if (!$this->classMetadataFactory->hasMetadataFor($class)) {
             return null;
         }
 
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/SerializerExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/SerializerExtractorTest.php
@@ -55,4 +55,9 @@ public function testGetPropertiesWithAnyGroup()
     {
         $this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));
     }
+
+    public function testGetPropertiesWithNonExistentClassReturnsNull()
+    {
+        $this->assertSame(null, $this->extractor->getProperties('NonExistent'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function getProperties(string $class, array $context = []): ?array`
`34`	`34`	`return null;`
`35`	`35`	`}`
`36`	`36`
`37`		`- if (!$this->classMetadataFactory->getMetadataFor($class)) {`
	`37`	`+ if (!$this->classMetadataFactory->hasMetadataFor($class)) {`
`38`	`38`	`return null;`
`39`	`39`	`}`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -55,4 +55,9 @@ public function testGetPropertiesWithAnyGroup()`
`55`	`55`	`{`
`56`	`56`	`$this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));`
`57`	`57`	`}`
	`58`	`+`
	`59`	`+ public function testGetPropertiesWithNonExistentClassReturnsNull()`
	`60`	`+ {`
	`61`	`+ $this->assertSame(null, $this->extractor->getProperties('NonExistent'));`
	`62`	`+ }`
`58`	`63`	`}`