And back

smnandre · smnandre · commit 7c9dd5a447c2 · 2024-10-07T15:10:20.000+02:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php b/src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
@@ -174,12 +174,11 @@ public function toolbarStylesheetAction(): Response
         $this->cspHandler?->disableCsp();
 
         return new Response(
-            $content = $this->twig->render('@WebProfiler/Profiler/toolbar.css.twig'),
+            $this->twig->render('@WebProfiler/Profiler/toolbar.css.twig'),
             200,
             [
                 'Content-Type' => 'text/css',
-                'Cache-Control' => 'max-age=3600, private',
-                'ETag' => hash('xxh128', $content),
+                'Cache-Control' => 'max-age=600, private',
             ],
         );
     }
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php b/src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php
@@ -161,8 +161,7 @@ public function testToolbarStylesheetAction()
         $response = $controller->toolbarStylesheetAction();
         $this->assertSame(200, $response->getStatusCode());
         $this->assertSame('text/css', $response->headers->get('Content-Type'));
-        $this->assertSame('max-age=3600, private', $response->headers->get('Cache-Control'));
-        $this->assertSame('99aa06d3014798d86001c324468d497f', $response->headers->get('ETag'));
+        $this->assertSame('max-age=600, private', $response->headers->get('Cache-Control'));
     }
 
     public static function getEmptyTokenCases()

Original file line number	Diff line number	Diff line change
`@@ -174,12 +174,11 @@ public function toolbarStylesheetAction(): Response`
`174`	`174`	`$this->cspHandler?->disableCsp();`
`175`	`175`
`176`	`176`	`return new Response(`
`177`		`- $content = $this->twig->render('@WebProfiler/Profiler/toolbar.css.twig'),`
	`177`	`+ $this->twig->render('@WebProfiler/Profiler/toolbar.css.twig'),`
`178`	`178`	`200,`
`179`	`179`	`[`
`180`	`180`	`'Content-Type' => 'text/css',`
`181`		`- 'Cache-Control' => 'max-age=3600, private',`
`182`		`- 'ETag' => hash('xxh128', $content),`
	`181`	`+ 'Cache-Control' => 'max-age=600, private',`
`183`	`182`	`],`
`184`	`183`	`);`
`185`	`184`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,8 +161,7 @@ public function testToolbarStylesheetAction()`
`161`	`161`	`$response = $controller->toolbarStylesheetAction();`
`162`	`162`	`$this->assertSame(200, $response->getStatusCode());`
`163`	`163`	`$this->assertSame('text/css', $response->headers->get('Content-Type'));`
`164`		`- $this->assertSame('max-age=3600, private', $response->headers->get('Cache-Control'));`
`165`		`- $this->assertSame('99aa06d3014798d86001c324468d497f', $response->headers->get('ETag'));`
	`164`	`+ $this->assertSame('max-age=600, private', $response->headers->get('Cache-Control'));`
`166`	`165`	`}`
`167`	`166`
`168`	`167`	`public static function getEmptyTokenCases()`