feature #61179 [DependencyInjection] Remove !tagged tag, use !tagged_iterator instead (nicolas-grekas)

chalasr · chalasr · commit 7d3f4fe11355 · 2025-07-21T17:14:25.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [DependencyInjection] Remove `!tagged` tag, use `!tagged_iterator` instead | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Commits ------- b4868bd [DependencyInjection] Remove `!tagged` tag, use `!tagged_iterator` instead
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -122,7 +122,7 @@ DependencyInjection
          public function __construct(#[AutowireIterator('app.my_tag')] private iterable $services) {}
     }
     ```
-
+ * Remove `!tagged` tag, use `!tagged_iterator` instead
  * Remove the `ContainerBuilder::getAutoconfiguredAttributes()` method, use `getAttributeAutoconfigurators()` instead to retrieve all the callbacks for a specific attribute class
 
 DoctrineBridge
diff --git a/src/Symfony/Component/DependencyInjection/CHANGELOG.md b/src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 
  * Remove `#[TaggedIterator]` and `#[TaggedLocator]` attributes, replaced by `#[AutowireLocator]` and `#[AutowireIterator]`
  * Remove `ContainerBuilder::getAutoconfiguredAttributes()`, replaced by `ContainerBuilder::getAttributeAutoconfigurators()`
+ * Remove `!tagged` tag, use `!tagged_iterator` instead
 
 7.4
 ---
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -630,9 +630,6 @@ private function getArgumentsAsPhp(\DOMElement $node, string $name, string $file
                     $arg = $this->getArgumentsAsPhp($arg, $name, $file);
                     $arguments[$key] = new ServiceLocatorArgument($arg);
                     break;
-                case 'tagged':
-                    trigger_deprecation('symfony/dependency-injection', '7.2', 'Type "tagged" is deprecated for tag <%s>, use "tagged_iterator" instead in "%s".', $name, $file);
-                    // no break
                 case 'tagged_iterator':
                 case 'tagged_locator':
                     $forLocator = 'tagged_locator' === $type;
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -852,11 +852,7 @@ private function resolveServices(mixed $value, string $file, bool $isParameter =
 
                 return new ServiceLocatorArgument($argument);
             }
-            if (\in_array($value->getTag(), ['tagged', 'tagged_iterator', 'tagged_locator'], true)) {
-                if ('tagged' === $value->getTag()) {
-                    trigger_deprecation('symfony/dependency-injection', '7.2', 'Using "!tagged" is deprecated, use "!tagged_iterator" instead in "%s".', $file);
-                }
-
+            if (\in_array($value->getTag(), ['tagged_iterator', 'tagged_locator'], true)) {
                 $forLocator = 'tagged_locator' === $value->getTag();
 
                 if (\is_array($argument) && isset($argument['tag']) && $argument['tag']) {
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_deprecated_tagged.xml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services_with_deprecated_tagged.xml
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
@@ -1335,19 +1335,6 @@ public function testUnknownConstantAsKey()
         $loader->load('key_type_wrong_constant.xml');
     }
 
-    /**
-     * @group legacy
-     */
-    public function testDeprecatedTagged()
-    {
-        $container = new ContainerBuilder();
-        $loader = new XmlFileLoader($container, new FileLocator(self::$fixturesPath.'/xml'));
-
-        $this->expectUserDeprecationMessage(\sprintf('Since symfony/dependency-injection 7.2: Type "tagged" is deprecated for tag <argument>, use "tagged_iterator" instead in "%s/xml%sservices_with_deprecated_tagged.xml".', self::$fixturesPath, \DIRECTORY_SEPARATOR));
-
-        $loader->load('services_with_deprecated_tagged.xml');
-    }
-
     public function testLoadServicesWithEnvironment()
     {
         $container = new ContainerBuilder();
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php
@@ -1211,17 +1211,4 @@ public function testStaticConstructor()
         $definition = $container->getDefinition('static_constructor');
         $this->assertEquals((new Definition('stdClass'))->setFactory([null, 'create']), $definition);
     }
-
-    /**
-     * @group legacy
-     */
-    public function testDeprecatedTagged()
-    {
-        $container = new ContainerBuilder();
-        $loader = new YamlFileLoader($container, new FileLocator(self::$fixturesPath.'/yaml'));
-
-        $this->expectUserDeprecationMessage(\sprintf('Since symfony/dependency-injection 7.2: Using "!tagged" is deprecated, use "!tagged_iterator" instead in "%s/yaml%stagged_deprecated.yml".', self::$fixturesPath, \DIRECTORY_SEPARATOR));
-
-        $loader->load('tagged_deprecated.yml');
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ DependencyInjection`
`122`	`122`	`public function __construct(#[AutowireIterator('app.my_tag')] private iterable $services) {}`
`123`	`123`	`}`
`124`	`124`	```
`125`		`-`
	`125`	+ * Remove `!tagged` tag, use `!tagged_iterator` instead
`126`	`126`	* Remove the `ContainerBuilder::getAutoconfiguredAttributes()` method, use `getAttributeAutoconfigurators()` instead to retrieve all the callbacks for a specific attribute class
`127`	`127`
`128`	`128`	`DoctrineBridge`