feature #14473 [DX] Minor improvement for the translation:debug output (nicolasdewez)

aitboudad · aitboudad · commit 7e29d2c999f5 · 2015-04-26T16:54:56.000+01:00
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #14473). Discussion ---------- [DX] Minor improvement for the translation:debug output | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13874 Commits ------- b941bd3 Changed output for translation:debug command
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
@@ -168,7 +168,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         // Display header line
-        $headers = array('State(s)', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));
+        $headers = array('State', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));
         foreach ($fallbackCatalogues as $fallbackCatalogue) {
             $headers[] = sprintf('Fallback Message Preview (%s)', $fallbackCatalogue->getLocale());
         }
@@ -215,26 +215,20 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } else {
             $table->render($output);
         }
-
-        $output->writeln('');
-        $output->writeln('<info>Legend:</info>');
-        $output->writeln(sprintf(' %s Missing message', $this->formatState(self::MESSAGE_MISSING)));
-        $output->writeln(sprintf(' %s Unused message', $this->formatState(self::MESSAGE_UNUSED)));
-        $output->writeln(sprintf(' %s Same as the fallback message', $this->formatState(self::MESSAGE_EQUALS_FALLBACK)));
     }
 
     private function formatState($state)
     {
         if (self::MESSAGE_MISSING === $state) {
-            return '<fg=red>x</>';
+            return '<error>missing</error>';
         }
 
         if (self::MESSAGE_UNUSED === $state) {
-            return '<fg=yellow>o</>';
+            return '<comment>unused</comment>';
         }
 
         if (self::MESSAGE_EQUALS_FALLBACK === $state) {
-            return '<fg=green>=</>';
+            return '<info>fallback</info>';
         }
 
         return $state;

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`// Display header line`
`171`		`- $headers = array('State(s)', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));`
	`171`	`+ $headers = array('State', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));`
`172`	`172`	`foreach ($fallbackCatalogues as $fallbackCatalogue) {`
`173`	`173`	`$headers[] = sprintf('Fallback Message Preview (%s)', $fallbackCatalogue->getLocale());`
`174`	`174`	`}`
`@@ -215,26 +215,20 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`215`	`215`	`} else {`
`216`	`216`	`$table->render($output);`
`217`	`217`	`}`
`218`		`-`
`219`		`- $output->writeln('');`
`220`		`- $output->writeln('<info>Legend:</info>');`
`221`		`- $output->writeln(sprintf(' %s Missing message', $this->formatState(self::MESSAGE_MISSING)));`
`222`		`- $output->writeln(sprintf(' %s Unused message', $this->formatState(self::MESSAGE_UNUSED)));`
`223`		`- $output->writeln(sprintf(' %s Same as the fallback message', $this->formatState(self::MESSAGE_EQUALS_FALLBACK)));`
`224`	`218`	`}`
`225`	`219`
`226`	`220`	`private function formatState($state)`
`227`	`221`	`{`
`228`	`222`	`if (self::MESSAGE_MISSING === $state) {`
`229`		`- return '<fg=red>x</>';`
	`223`	`+ return '<error>missing</error>';`
`230`	`224`	`}`
`231`	`225`
`232`	`226`	`if (self::MESSAGE_UNUSED === $state) {`
`233`		`- return '<fg=yellow>o</>';`
	`227`	`+ return '<comment>unused</comment>';`
`234`	`228`	`}`
`235`	`229`
`236`	`230`	`if (self::MESSAGE_EQUALS_FALLBACK === $state) {`
`237`		`- return '<fg=green>=</>';`
	`231`	`+ return '<info>fallback</info>';`
`238`	`232`	`}`
`239`	`233`
`240`	`234`	`return $state;`