bug #35170 [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr (fancyweb)

fabpot · fabpot · commit 7fa87b46e3f1 · 2020-01-07T20:18:41.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34865 (comment) | License | MIT | Doc PR | - Outputing everything on stderr seems wrong. I'm going to check upper branches. Commits ------- 87212e4 [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -200,12 +200,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
-        $errorIo->title('Translation Messages Extractor and Dumper');
-        $errorIo->comment(sprintf('Generating "<info>%s</info>" translation files for "<info>%s</info>"', $input->getArgument('locale'), $currentName));
+        $io->title('Translation Messages Extractor and Dumper');
+        $io->comment(sprintf('Generating "<info>%s</info>" translation files for "<info>%s</info>"', $input->getArgument('locale'), $currentName));
 
         // load any messages from templates
         $extractedCatalogue = new MessageCatalogue($input->getArgument('locale'));
-        $errorIo->comment('Parsing templates...');
+        $io->comment('Parsing templates...');
         $prefix = $input->getOption('prefix');
         // @deprecated since version 3.4, to be removed in 4.0 along with the --no-prefix option
         if ($input->getOption('no-prefix')) {
@@ -221,7 +221,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // load any existing messages from the translation files
         $currentCatalogue = new MessageCatalogue($input->getArgument('locale'));
-        $errorIo->comment('Loading translation files...');
+        $io->comment('Loading translation files...');
         foreach ($transPaths as $path) {
             if (is_dir($path)) {
                 $this->reader->read($path, $currentCatalogue);
@@ -274,7 +274,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
 
             if ('xlf' == $input->getOption('output-format')) {
-                $errorIo->comment('Xliff output version is <info>1.2</info>');
+                $io->comment('Xliff output version is <info>1.2</info>');
             }
 
             $resultMessage = sprintf('%d message%s successfully extracted', $extractedMessagesCount, $extractedMessagesCount > 1 ? 's were' : ' was');
@@ -286,7 +286,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // save the files
         if (true === $input->getOption('force')) {
-            $errorIo->comment('Writing files...');
+            $io->comment('Writing files...');
 
             $bundleTransPath = false;
             foreach ($transPaths as $path) {
@@ -306,7 +306,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
 
-        $errorIo->success($resultMessage.'.');
+        $io->success($resultMessage.'.');
 
         return null;
     }

Original file line number	Diff line number	Diff line change
`@@ -200,12 +200,12 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`200`	`200`	`}`
`201`	`201`	`}`
`202`	`202`
`203`		`- $errorIo->title('Translation Messages Extractor and Dumper');`
`204`		`- $errorIo->comment(sprintf('Generating "<info>%s</info>" translation files for "<info>%s</info>"', $input->getArgument('locale'), $currentName));`
	`203`	`+ $io->title('Translation Messages Extractor and Dumper');`
	`204`	`+ $io->comment(sprintf('Generating "<info>%s</info>" translation files for "<info>%s</info>"', $input->getArgument('locale'), $currentName));`
`205`	`205`
`206`	`206`	`// load any messages from templates`
`207`	`207`	`$extractedCatalogue = new MessageCatalogue($input->getArgument('locale'));`
`208`		`- $errorIo->comment('Parsing templates...');`
	`208`	`+ $io->comment('Parsing templates...');`
`209`	`209`	`$prefix = $input->getOption('prefix');`
`210`	`210`	`// @deprecated since version 3.4, to be removed in 4.0 along with the --no-prefix option`
`211`	`211`	`if ($input->getOption('no-prefix')) {`
`@@ -221,7 +221,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`221`	`221`
`222`	`222`	`// load any existing messages from the translation files`
`223`	`223`	`$currentCatalogue = new MessageCatalogue($input->getArgument('locale'));`
`224`		`- $errorIo->comment('Loading translation files...');`
	`224`	`+ $io->comment('Loading translation files...');`
`225`	`225`	`foreach ($transPaths as $path) {`
`226`	`226`	`if (is_dir($path)) {`
`227`	`227`	`$this->reader->read($path, $currentCatalogue);`
`@@ -274,7 +274,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`274`	`274`	`}`
`275`	`275`
`276`	`276`	`if ('xlf' == $input->getOption('output-format')) {`
`277`		`- $errorIo->comment('Xliff output version is <info>1.2</info>');`
	`277`	`+ $io->comment('Xliff output version is <info>1.2</info>');`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`$resultMessage = sprintf('%d message%s successfully extracted', $extractedMessagesCount, $extractedMessagesCount > 1 ? 's were' : ' was');`
`@@ -286,7 +286,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`286`	`286`
`287`	`287`	`// save the files`
`288`	`288`	`if (true === $input->getOption('force')) {`
`289`		`- $errorIo->comment('Writing files...');`
	`289`	`+ $io->comment('Writing files...');`
`290`	`290`
`291`	`291`	`$bundleTransPath = false;`
`292`	`292`	`foreach ($transPaths as $path) {`
`@@ -306,7 +306,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`306`	`306`	`}`
`307`	`307`	`}`
`308`	`308`
`309`		`- $errorIo->success($resultMessage.'.');`
	`309`	`+ $io->success($resultMessage.'.');`
`310`	`310`
`311`	`311`	`return null;`
`312`	`312`	`}`