minor #59690 [Process] Fix process status tracking (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 819e3e8146f0 · 2025-02-04T14:43:21.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Process] Fix process status tracking | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT :crossed_fingers: Commits ------- c237f8e [Process] Fix process status tracking
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -80,7 +80,6 @@ class Process implements \IteratorAggregate
     private WindowsPipes|UnixPipes $processPipes;
 
     private ?int $latestSignal = null;
-    private ?int $cachedExitCode = null;
 
     private static ?bool $sigchild = null;
 
@@ -1289,21 +1288,10 @@ protected function updateStatus(bool $blocking)
             return;
         }
 
-        $this->processInformation = proc_get_status($this->process);
-        $running = $this->processInformation['running'];
-
-        // In PHP < 8.3, "proc_get_status" only returns the correct exit status on the first call.
-        // Subsequent calls return -1 as the process is discarded. This workaround caches the first
-        // retrieved exit status for consistent results in later calls, mimicking PHP 8.3 behavior.
-        if (\PHP_VERSION_ID < 80300) {
-            if (!isset($this->cachedExitCode) && !$running && -1 !== $this->processInformation['exitcode']) {
-                $this->cachedExitCode = $this->processInformation['exitcode'];
-            }
-
-            if (isset($this->cachedExitCode) && !$running && -1 === $this->processInformation['exitcode']) {
-                $this->processInformation['exitcode'] = $this->cachedExitCode;
-            }
+        if ($this->processInformation['running'] ?? true) {
+            $this->processInformation = proc_get_status($this->process);
         }
+        $running = $this->processInformation['running'];
 
         $this->readPipes($running && $blocking, '\\' !== \DIRECTORY_SEPARATOR || !$running);
 
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -711,6 +711,9 @@ public function testProcessIsSignaledIfStopped()
         if ('\\' === \DIRECTORY_SEPARATOR) {
             $this->markTestSkipped('Windows does not support POSIX signals');
         }
+        if (\PHP_VERSION_ID < 80300 && isset($_SERVER['GITHUB_ACTIONS'])) {
+            $this->markTestSkipped('Transient on GHA with PHP < 8.3');
+        }
 
         $process = $this->getProcessForCode('sleep(32);');
         $process->start();

Original file line number	Diff line number	Diff line change
`@@ -711,6 +711,9 @@ public function testProcessIsSignaledIfStopped()`
`711`	`711`	`if ('\\' === \DIRECTORY_SEPARATOR) {`
`712`	`712`	`$this->markTestSkipped('Windows does not support POSIX signals');`
`713`	`713`	`}`
	`714`	`+ if (\PHP_VERSION_ID < 80300 && isset($_SERVER['GITHUB_ACTIONS'])) {`
	`715`	`+ $this->markTestSkipped('Transient on GHA with PHP < 8.3');`
	`716`	`+ }`
`714`	`717`
`715`	`718`	`$process = $this->getProcessForCode('sleep(32);');`
`716`	`719`	`$process->start();`