minor #58951 add comment explaining why HttpClient tests are run separately (xabbuh)

nicolas-grekas · nicolas-grekas · commit 85419bc56b6f · 2024-11-20T17:27:03.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- add comment explaining why HttpClient tests are run separately | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see #35115 and #58916 Commits ------- cbdb08a add comment explaining why HttpClient tests are run separately
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -110,6 +110,7 @@ jobs:
           Remove-Item -Path src\Symfony\Bridge\PhpUnit -Recurse
           mv src\Symfony\Component\HttpClient\phpunit.xml.dist src\Symfony\Component\HttpClient\phpunit.xml
           php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
+          # HttpClient tests need to run separately, they block when run with other components' tests concurrently
           php phpunit src\Symfony\Component\HttpClient || ($x = 1)
 
           exit $x
@@ -123,6 +124,7 @@ jobs:
 
           Copy c:\php\php.ini-max c:\php\php.ini
           php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
+          # HttpClient tests need to run separately, they block when run with other components' tests concurrently
           php phpunit src\Symfony\Component\HttpClient || ($x = 1)
 
           exit $x
