bug #45103 [Process] Avoid calling fclose on an already closed resource (Seldaek)

nicolas-grekas · nicolas-grekas · commit 859d4a1fbc43 · 2022-01-24T20:34:11.000+01:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Process] Avoid calling fclose on an already closed resource | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  I got this in Composer while interrupting an install process with Ctrl-C. ``` PHP Fatal error: Uncaught TypeError: fclose(): supplied resource is not a valid stream resource in /var/www/composer/vendor/symfony/process/Pipes/AbstractPipes.php:50 Stack trace: #0 /var/www/composer/vendor/symfony/process/Pipes/AbstractPipes.php(50): fclose() #1 /var/www/composer/vendor/symfony/process/Pipes/UnixPipes.php(50): Symfony\Component\Process\Pipes\AbstractPipes->close() #2 [internal function]: Symfony\Component\Process\Pipes\UnixPipes->__destruct() #3 {main} thrown in /var/www/composer/vendor/symfony/process/Pipes/AbstractPipes.php on line 50 ``` I am assuming it's due to a process which was not closed properly, which is very likely given we run a bunch of them concurrently.. It's pretty hard to debug as it's also hard to reproduce, so I am not sure what to do except handle this case gracefully in the close/__destruct function and hope that at least lets it clean up processes without crashing this way. Commits ------- a9e43a7 [Process] Avoid calling fclose on an already closed resource
diff --git a/src/Symfony/Component/Process/Pipes/AbstractPipes.php b/src/Symfony/Component/Process/Pipes/AbstractPipes.php
@@ -47,7 +47,9 @@ public function __construct($input)
     public function close()
     {
         foreach ($this->pipes as $pipe) {
-            fclose($pipe);
+            if (\is_resource($pipe)) {
+                fclose($pipe);
+            }
         }
         $this->pipes = [];
     }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,9 @@ public function __construct($input)`
`47`	`47`	`public function close()`
`48`	`48`	`{`
`49`	`49`	`foreach ($this->pipes as $pipe) {`
`50`		`- fclose($pipe);`
	`50`	`+ if (\is_resource($pipe)) {`
	`51`	`+ fclose($pipe);`
	`52`	`+ }`
`51`	`53`	`}`
`52`	`54`	`$this->pipes = [];`
`53`	`55`	`}`