bug #51114 [Serializer] Fix denormalizing abstract part headers in MimeMessageNormalizer (fancyweb)

nicolas-grekas · nicolas-grekas · commit 8b2627b5317f · 2023-07-26T19:18:10.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] Fix denormalizing abstract part headers in MimeMessageNormalizer | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - `AbstractPart::$headers` property is not denormalized to the `Headers` object but remains an array. Commits ------- 3784115 [Serializer] Fix denormalizing abstract part headers in MimeMessageNormalizer
diff --git a/src/Symfony/Component/Mime/Tests/MessageTest.php b/src/Symfony/Component/Mime/Tests/MessageTest.php
@@ -168,6 +168,7 @@ public function testSymfonySerialize()
             ),
             new DataPart('text data', 'text.txt')
         );
+        $body->getHeaders()->addHeader('foo', 'bar');
         $e = new Message((new Headers())->addMailboxListHeader('To', ['you@example.com']), $body);
         $expected = clone $e;
 
@@ -232,7 +233,17 @@ public function testSymfonySerialize()
                 "class": "Symfony\\\\Component\\\\Mime\\\\Part\\\\DataPart"
             }
         ],
-        "headers": [],
+        "headers": {
+            "foo": [
+                {
+                    "value": "bar",
+                    "name": "foo",
+                    "lineLength": 76,
+                    "lang": null,
+                    "charset": "utf-8"
+                }
+            ]
+        },
         "class": "Symfony\\\\Component\\\\Mime\\\\Part\\\\Multipart\\\\MixedPart"
     },
     "message": null
@@ -252,7 +263,7 @@ public function testSymfonySerialize()
         $this->assertSame($expectedJson, json_encode(json_decode($serialized), \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES));
 
         $n = $serializer->deserialize($serialized, Message::class, 'json');
-        $this->assertEquals($expected->getHeaders(), $n->getHeaders());
+        $this->assertEquals($expected, $n);
 
         $serialized = $serializer->serialize($e, 'json');
         $this->assertSame($expectedJson, json_encode(json_decode($serialized), \JSON_PRETTY_PRINT | \JSON_UNESCAPED_SLASHES));
diff --git a/src/Symfony/Component/Mime/composer.json b/src/Symfony/Component/Mime/composer.json
@@ -28,14 +28,14 @@
         "symfony/dependency-injection": "^4.4|^5.0|^6.0",
         "symfony/property-access": "^4.4|^5.1|^6.0",
         "symfony/property-info": "^4.4|^5.1|^6.0",
-        "symfony/serializer": "^5.4.14|~6.0.14|^6.1.6"
+        "symfony/serializer": "^5.4.26|^6.2.13"
     },
     "conflict": {
         "egulias/email-validator": "~3.0.0",
         "phpdocumentor/reflection-docblock": "<3.2.2",
         "phpdocumentor/type-resolver": "<1.4.0",
         "symfony/mailer": "<4.4",
-        "symfony/serializer": "<5.4.14|>=6.0,<6.0.14|>=6.1,<6.1.6"
+        "symfony/serializer": "<5.4.26|>=6.2,<6.2.13"
     },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Mime\\": "" },
diff --git a/src/Symfony/Component/Serializer/Normalizer/MimeMessageNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/MimeMessageNormalizer.php
@@ -93,6 +93,7 @@ public function denormalize($data, string $type, string $format = null, array $c
         if (AbstractPart::class === $type) {
             $type = $data['class'];
             unset($data['class']);
+            $data['headers'] = $this->serializer->denormalize($data['headers'], Headers::class, $format, $context);
         }
 
         return $this->normalizer->denormalize($data, $type, $format, $context);

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ public function denormalize($data, string $type, string $format = null, array $c`
`93`	`93`	`if (AbstractPart::class === $type) {`
`94`	`94`	`$type = $data['class'];`
`95`	`95`	`unset($data['class']);`
	`96`	`+ $data['headers'] = $this->serializer->denormalize($data['headers'], Headers::class, $format, $context);`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`return $this->normalizer->denormalize($data, $type, $format, $context);`