Bind input before executing the COMMAND event

wouterj · wouterj · commit 8bd327f2789e · 2015-09-27T13:24:29.000+02:00
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -880,6 +880,10 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
             return $command->run($input, $output);
         }
 
+        // bind before the console.command event, so the listeners have access to input options/arguments
+        $command->mergeApplicationDefinition();
+        $input->bind($command->getDefinition());
+
         $event = new ConsoleCommandEvent($command, $input, $output);
         $this->dispatcher->dispatch(ConsoleEvents::COMMAND, $event);
 
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -943,6 +943,34 @@ public function testRunWithDispatcherSkippingCommand()
         $this->assertEquals(ConsoleCommandEvent::RETURN_CODE_DISABLED, $exitCode);
     }
 
+    public function testRunWithDispatcherAccessingInputOptions()
+    {
+        $noInteractionValue = null;
+        $quietValue = null;
+
+        $dispatcher = $this->getDispatcher();
+        $dispatcher->addListener('console.command', function (ConsoleCommandEvent $event) use (&$noInteractionValue, &$quietValue) {
+            $input = $event->getInput();
+
+            $noInteractionValue = $input->getOption('no-interaction');
+            $quietValue = $input->getOption('quiet');
+        });
+
+        $application = new Application();
+        $application->setDispatcher($dispatcher);
+        $application->setAutoExit(false);
+
+        $application->register('foo')->setCode(function (InputInterface $input, OutputInterface $output) {
+            $output->write('foo.');
+        });
+
+        $tester = new ApplicationTester($application);
+        $tester->run(array('command' => 'foo', '--no-interaction' => true));
+
+        $this->assertTrue($noInteractionValue);
+        $this->assertFalse($quietValue);
+    }
+
     public function testTerminalDimensions()
     {
         $application = new Application();

Original file line number	Diff line number	Diff line change
`@@ -880,6 +880,10 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI`
`880`	`880`	`return $command->run($input, $output);`
`881`	`881`	`}`
`882`	`882`
	`883`	`+ // bind before the console.command event, so the listeners have access to input options/arguments`
	`884`	`+ $command->mergeApplicationDefinition();`
	`885`	`+ $input->bind($command->getDefinition());`
	`886`	`+`
`883`	`887`	`$event = new ConsoleCommandEvent($command, $input, $output);`
`884`	`888`	`$this->dispatcher->dispatch(ConsoleEvents::COMMAND, $event);`
`885`	`889`