[CssSelector] Support *:only-of-type

jakzal · jakzal · commit 8fc5aebdcb77 · 2019-10-05T08:07:15.000+02:00
diff --git a/src/Symfony/Component/CssSelector/CHANGELOG.md b/src/Symfony/Component/CssSelector/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.4.0
+-----
+
+ * Added support for `*:only-of-type`
+
 2.8.0
 -----
 
diff --git a/src/Symfony/Component/CssSelector/Tests/XPath/TranslatorTest.php b/src/Symfony/Component/CssSelector/Tests/XPath/TranslatorTest.php
@@ -308,6 +308,8 @@ public function getHtmlIdsTestData()
             ['li div:only-child', ['li-div']],
             ['div *:only-child', ['li-div', 'foobar-span']],
             ['p:only-of-type', ['paragraph']],
+            [':only-of-type', ['html', 'li-div', 'foobar-span', 'paragraph']],
+            ['div#foobar-div :only-of-type', ['foobar-span']],
             ['a:empty', ['name-anchor']],
             ['a:EMpty', ['name-anchor']],
             ['li:empty', ['third-li', 'fourth-li', 'fifth-li', 'sixth-li']],
diff --git a/src/Symfony/Component/CssSelector/XPath/Extension/PseudoClassExtension.php b/src/Symfony/Component/CssSelector/XPath/Extension/PseudoClassExtension.php
@@ -100,17 +100,10 @@ public function translateOnlyChild(XPathExpr $xpath): XPathExpr
             ->addCondition('last() = 1');
     }
 
-    /**
-     * @throws ExpressionErrorException
-     */
     public function translateOnlyOfType(XPathExpr $xpath): XPathExpr
     {
         $element = $xpath->getElement();
 
-        if ('*' === $element) {
-            throw new ExpressionErrorException('"*:only-of-type" is not implemented.');
-        }
-
         return $xpath->addCondition(sprintf('count(preceding-sibling::%s)=0 and count(following-sibling::%s)=0', $element, $element));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -100,17 +100,10 @@ public function translateOnlyChild(XPathExpr $xpath): XPathExpr`
`100`	`100`	`->addCondition('last() = 1');`
`101`	`101`	`}`
`102`	`102`
`103`		`- /**`
`104`		`- * @throws ExpressionErrorException`
`105`		`- */`
`106`	`103`	`public function translateOnlyOfType(XPathExpr $xpath): XPathExpr`
`107`	`104`	`{`
`108`	`105`	`$element = $xpath->getElement();`
`109`	`106`
`110`		`- if ('*' === $element) {`
`111`		`- throw new ExpressionErrorException('"*:only-of-type" is not implemented.');`
`112`		`- }`
`113`		`-`
`114`	`107`	`return $xpath->addCondition(sprintf('count(preceding-sibling::%s)=0 and count(following-sibling::%s)=0', $element, $element));`
`115`	`108`	`}`
`116`	`109`