[ClassLoader] Fix storing not-found classes in APC cache

nicolas-grekas · nicolas-grekas · commit 90360c856bf9 · 2016-03-27T11:30:32.000+02:00
diff --git a/src/Symfony/Component/ClassLoader/ApcClassLoader.php b/src/Symfony/Component/ClassLoader/ApcClassLoader.php
@@ -122,8 +122,10 @@ public function loadClass($class)
      */
     public function findFile($class)
     {
-        if (false === $file = apcu_fetch($this->prefix.$class)) {
-            apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class));
+        $file = apcu_fetch($this->prefix.$class, $success);
+
+        if (!$success) {
+            apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class) ?: null);
         }
 
         return $file;

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,10 @@ public function loadClass($class)`
`122`	`122`	`*/`
`123`	`123`	`public function findFile($class)`
`124`	`124`	`{`
`125`		`- if (false === $file = apcu_fetch($this->prefix.$class)) {`
`126`		`- apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class));`
	`125`	`+ $file = apcu_fetch($this->prefix.$class, $success);`
	`126`	`+`
	`127`	`+ if (!$success) {`
	`128`	`+ apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class) ?: null);`
`127`	`129`	`}`
`128`	`130`
`129`	`131`	`return $file;`