Make some classes final

lyrixx · lyrixx · commit 9047ce6a32bf · 2023-06-14T15:02:29.000+02:00
diff --git a/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php b/src/Symfony/Bridge/Monolog/Formatter/ConsoleFormatter.php
@@ -25,10 +25,8 @@
  *
  * @author Tobias Schultze <http://tobion.de>
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
- *
- * @final since Symfony 6.1
  */
-class ConsoleFormatter implements FormatterInterface
+final class ConsoleFormatter implements FormatterInterface
 {
     use CompatibilityFormatter;
 
diff --git a/src/Symfony/Bridge/Monolog/Formatter/VarDumperFormatter.php b/src/Symfony/Bridge/Monolog/Formatter/VarDumperFormatter.php
@@ -17,10 +17,8 @@
 
 /**
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
- *
- * @final since Symfony 6.1
  */
-class VarDumperFormatter implements FormatterInterface
+final class VarDumperFormatter implements FormatterInterface
 {
     use CompatibilityFormatter;
 
diff --git a/src/Symfony/Bridge/Monolog/Handler/ConsoleHandler.php b/src/Symfony/Bridge/Monolog/Handler/ConsoleHandler.php
@@ -77,10 +77,8 @@ public function isHandling(array $record): bool
  * This mapping can be customized with the $verbosityLevelMap constructor parameter.
  *
  * @author Tobias Schultze <http://tobion.de>
- *
- * @final since Symfony 6.1
  */
-class ConsoleHandler extends AbstractProcessingHandler implements EventSubscriberInterface
+final class ConsoleHandler extends AbstractProcessingHandler implements EventSubscriberInterface
 {
     use CompatibilityHandler;
     use CompatibilityIsHandlingHandler;
diff --git a/src/Symfony/Bridge/Monolog/Handler/ElasticsearchLogstashHandler.php b/src/Symfony/Bridge/Monolog/Handler/ElasticsearchLogstashHandler.php
@@ -41,10 +41,8 @@
  * stack is recommended.
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
- *
- * @final since Symfony 6.1
  */
-class ElasticsearchLogstashHandler extends AbstractHandler
+final class ElasticsearchLogstashHandler extends AbstractHandler
 {
     use CompatibilityHandler;
 
diff --git a/src/Symfony/Bridge/Monolog/Handler/MailerHandler.php b/src/Symfony/Bridge/Monolog/Handler/MailerHandler.php
@@ -23,10 +23,8 @@
 
 /**
  * @author Alexander Borisov <boshurik@gmail.com>
- *
- * @final since Symfony 6.1
  */
-class MailerHandler extends AbstractProcessingHandler
+final class MailerHandler extends AbstractProcessingHandler
 {
     use CompatibilityProcessingHandler;
 
diff --git a/src/Symfony/Bridge/Monolog/Handler/NotifierHandler.php b/src/Symfony/Bridge/Monolog/Handler/NotifierHandler.php
@@ -16,17 +16,14 @@
 use Monolog\Logger;
 use Monolog\LogRecord;
 use Symfony\Component\Notifier\Notification\Notification;
-use Symfony\Component\Notifier\Notifier;
 use Symfony\Component\Notifier\NotifierInterface;
 
 /**
  * Uses Notifier as a log handler.
  *
  * @author Fabien Potencier <fabien@symfony.com>
- *
- * @final since Symfony 6.1
  */
-class NotifierHandler extends AbstractHandler
+final class NotifierHandler extends AbstractHandler
 {
     use CompatibilityHandler;
 
diff --git a/src/Symfony/Bridge/Monolog/Handler/ServerLogHandler.php b/src/Symfony/Bridge/Monolog/Handler/ServerLogHandler.php
@@ -20,10 +20,7 @@
 use Symfony\Bridge\Monolog\Formatter\VarDumperFormatter;
 
 if (trait_exists(FormattableHandlerTrait::class)) {
-    /**
-     * @final since Symfony 6.1
-     */
-    class ServerLogHandler extends AbstractProcessingHandler
+    final class ServerLogHandler extends AbstractProcessingHandler
     {
         use CompatibilityHandler;
         use CompatibilityProcessingHandler;
@@ -35,10 +32,7 @@ protected function getDefaultFormatter(): FormatterInterface
         }
     }
 } else {
-    /**
-     * @final since Symfony 6.1
-     */
-    class ServerLogHandler extends AbstractProcessingHandler
+    final class ServerLogHandler extends AbstractProcessingHandler
     {
         use CompatibilityHandler;
         use CompatibilityProcessingHandler;
diff --git a/src/Symfony/Bridge/Monolog/Processor/ConsoleCommandProcessor.php b/src/Symfony/Bridge/Monolog/Processor/ConsoleCommandProcessor.php
@@ -21,10 +21,8 @@
  * Adds the current console command information to the log entry.
  *
  * @author Piotr Stankowski <git@trakos.pl>
- *
- * @final since Symfony 6.1
  */
-class ConsoleCommandProcessor implements EventSubscriberInterface, ResetInterface
+final class ConsoleCommandProcessor implements EventSubscriberInterface, ResetInterface
 {
     use CompatibilityProcessor;
 
diff --git a/src/Symfony/Bridge/Monolog/Processor/SwitchUserTokenProcessor.php b/src/Symfony/Bridge/Monolog/Processor/SwitchUserTokenProcessor.php
@@ -18,10 +18,8 @@
  * Adds the original security token to the log entry.
  *
  * @author Igor Timoshenko <igor.timoshenko@i.ua>
- *
- * @final since Symfony 6.1
  */
-class SwitchUserTokenProcessor extends AbstractTokenProcessor
+final class SwitchUserTokenProcessor extends AbstractTokenProcessor
 {
     protected function getKey(): string
     {
diff --git a/src/Symfony/Bridge/Monolog/Processor/TokenProcessor.php b/src/Symfony/Bridge/Monolog/Processor/TokenProcessor.php
@@ -18,10 +18,8 @@
  *
  * @author Dany Maillard <danymaillard93b@gmail.com>
  * @author Igor Timoshenko <igor.timoshenko@i.ua>
- *
- * @final since Symfony 6.1
  */
-class TokenProcessor extends AbstractTokenProcessor
+final class TokenProcessor extends AbstractTokenProcessor
 {
     protected function getKey(): string
     {
diff --git a/src/Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php b/src/Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php
@@ -15,7 +15,7 @@
 use Symfony\Bridge\ErrorHandler\Tests\Fixtures\ExtendsDeprecatedParent;
 use Symfony\Component\ErrorHandler\DebugClassLoader;
 
-class DebugClassLoaderTest extends TestCase
+final class DebugClassLoaderTest extends TestCase
 {
     private $patchTypes;
     private $errorReporting;
diff --git a/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/BackedEnumValueResolver.php b/src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/BackedEnumValueResolver.php
@@ -22,10 +22,8 @@
  * leading to a 404 Not Found if the attribute value isn't a valid backing value for the enum type.
  *
  * @author Maxime Steinhausser <maxime.steinhausser@gmail.com>
- *
- * @final since Symfony 6.2
  */
-class BackedEnumValueResolver implements ArgumentValueResolverInterface, ValueResolverInterface
+final class BackedEnumValueResolver implements ArgumentValueResolverInterface, ValueResolverInterface
 {
     /**
      * @deprecated since Symfony 6.2, use resolve() instead
diff --git a/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php b/src/Symfony/Component/Mailer/Transport/Smtp/SmtpTransport.php
@@ -29,7 +29,7 @@
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Chris Corbyn
  */
-class SmtpTransport extends AbstractTransport
+final class SmtpTransport extends AbstractTransport
 {
     private bool $started = false;
     private int $restartThreshold = 100;
@@ -244,12 +244,7 @@ protected function doSend(SentMessage $message): void
         }
     }
 
-    /**
-     * @internal since version 6.1, to be made private in 7.0
-     *
-     * @final since version 6.1, to be made private in 7.0
-     */
-    protected function doHeloCommand(): void
+    private function doHeloCommand(): void
     {
         $this->executeCommand(sprintf("HELO %s\r\n", $this->domain), [250]);
     }
diff --git a/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
@@ -21,10 +21,8 @@
  *
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
  * @author Kévin Dunglas <dunglas@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class ConstraintViolationListNormalizer implements NormalizerInterface, CacheableSupportsMethodInterface
+final class ConstraintViolationListNormalizer implements NormalizerInterface, CacheableSupportsMethodInterface
 {
     public const INSTANCE = 'instance';
     public const STATUS = 'status';
diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -16,10 +16,8 @@
 
 /**
  * @author Jordi Boggiano <j.boggiano@seld.be>
- *
- * @final since Symfony 6.3
  */
-class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, CacheableSupportsMethodInterface
+final class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, SerializerAwareInterface, CacheableSupportsMethodInterface
 {
     use ObjectToPopulateTrait;
     use SerializerAwareTrait;
diff --git a/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
@@ -22,10 +22,8 @@
  * Denormalizes a data URI to a {@see \SplFileObject} object.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
+final class DataUriNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
     private const SUPPORTED_TYPES = [
         \SplFileInfo::class => true,
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -19,10 +19,8 @@
  * Denormalizes an interval string to an instance of {@see \DateInterval}.
  *
  * @author Jérôme Parmentier <jerome@prmntr.me>
- *
- * @final since Symfony 6.3
  */
-class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
+final class DateIntervalNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
     public const FORMAT_KEY = 'dateinterval_format';
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -20,10 +20,8 @@
  * Denormalizes a date string to an instance of {@see \DateTime} or {@see \DateTimeImmutable}.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
+final class DateTimeNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
     public const FORMAT_KEY = 'datetime_format';
     public const TIMEZONE_KEY = 'datetime_timezone';
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php
@@ -19,10 +19,8 @@
  * Normalizes a {@see \DateTimeZone} object to a timezone string.
  *
  * @author Jérôme Desjardins <jewome62@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class DateTimeZoneNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
+final class DateTimeZoneNormalizer implements NormalizerInterface, DenormalizerInterface, CacheableSupportsMethodInterface
 {
     public function getSupportedTypes(?string $format): array
     {
diff --git a/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php
@@ -18,10 +18,8 @@
  * A normalizer that uses an objects own JsonSerializable implementation.
  *
  * @author Fred Cox <mcfedr@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class JsonSerializableNormalizer extends AbstractNormalizer
+final class JsonSerializableNormalizer extends AbstractNormalizer
 {
     public function normalize(mixed $object, string $format = null, array $context = []): array|string|int|float|bool|\ArrayObject|null
     {
diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
@@ -25,10 +25,8 @@
  * Converts between objects and arrays using the PropertyAccess component.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
- *
- * @final since Symfony 6.3
  */
-class ObjectNormalizer extends AbstractObjectNormalizer
+final class ObjectNormalizer extends AbstractObjectNormalizer
 {
     protected $propertyAccessor;
 

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,8 @@`
`25`	`25`	`*`
`26`	`26`	`* @author Tobias Schultze <http://tobion.de>`
`27`	`27`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`28`		`- *`
`29`		`- * @final since Symfony 6.1`
`30`	`28`	`*/`
`31`		`-class ConsoleFormatter implements FormatterInterface`
	`29`	`+final class ConsoleFormatter implements FormatterInterface`
`32`	`30`	`{`
`33`	`31`	`use CompatibilityFormatter;`
`34`	`32`
Original file line number	Diff line number	Diff line change
`@@ -77,10 +77,8 @@ public function isHandling(array $record): bool`
`77`	`77`	`* This mapping can be customized with the $verbosityLevelMap constructor parameter.`
`78`	`78`	`*`
`79`	`79`	`* @author Tobias Schultze <http://tobion.de>`
`80`		`- *`
`81`		`- * @final since Symfony 6.1`
`82`	`80`	`*/`
`83`		`-class ConsoleHandler extends AbstractProcessingHandler implements EventSubscriberInterface`
	`81`	`+final class ConsoleHandler extends AbstractProcessingHandler implements EventSubscriberInterface`
`84`	`82`	`{`
`85`	`83`	`use CompatibilityHandler;`
`86`	`84`	`use CompatibilityIsHandlingHandler;`
Original file line number	Diff line number	Diff line change
`@@ -41,10 +41,8 @@`
`41`	`41`	`* stack is recommended.`
`42`	`42`	`*`
`43`	`43`	`* @author Grégoire Pineau <lyrixx@lyrixx.info>`
`44`		`- *`
`45`		`- * @final since Symfony 6.1`
`46`	`44`	`*/`
`47`		`-class ElasticsearchLogstashHandler extends AbstractHandler`
	`45`	`+final class ElasticsearchLogstashHandler extends AbstractHandler`
`48`	`46`	`{`
`49`	`47`	`use CompatibilityHandler;`
`50`	`48`
Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,7 @@`
`20`	`20`	`use Symfony\Bridge\Monolog\Formatter\VarDumperFormatter;`
`21`	`21`
`22`	`22`	`if (trait_exists(FormattableHandlerTrait::class)) {`
`23`		`- /**`
`24`		`- * @final since Symfony 6.1`
`25`		`- */`
`26`		`- class ServerLogHandler extends AbstractProcessingHandler`
	`23`	`+ final class ServerLogHandler extends AbstractProcessingHandler`
`27`	`24`	`{`
`28`	`25`	`use CompatibilityHandler;`
`29`	`26`	`use CompatibilityProcessingHandler;`
`@@ -35,10 +32,7 @@ protected function getDefaultFormatter(): FormatterInterface`
`35`	`32`	`}`
`36`	`33`	`}`
`37`	`34`	`} else {`
`38`		`- /**`
`39`		`- * @final since Symfony 6.1`
`40`		`- */`
`41`		`- class ServerLogHandler extends AbstractProcessingHandler`
	`35`	`+ final class ServerLogHandler extends AbstractProcessingHandler`
`42`	`36`	`{`
`43`	`37`	`use CompatibilityHandler;`
`44`	`38`	`use CompatibilityProcessingHandler;`
Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,8 @@`
`21`	`21`	`* Adds the current console command information to the log entry.`
`22`	`22`	`*`
`23`	`23`	`* @author Piotr Stankowski <git@trakos.pl>`
`24`		`- *`
`25`		`- * @final since Symfony 6.1`
`26`	`24`	`*/`
`27`		`-class ConsoleCommandProcessor implements EventSubscriberInterface, ResetInterface`
	`25`	`+final class ConsoleCommandProcessor implements EventSubscriberInterface, ResetInterface`
`28`	`26`	`{`
`29`	`27`	`use CompatibilityProcessor;`
`30`	`28`
Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,8 @@`
`18`	`18`	`* Adds the original security token to the log entry.`
`19`	`19`	`*`
`20`	`20`	`* @author Igor Timoshenko <igor.timoshenko@i.ua>`
`21`		`- *`
`22`		`- * @final since Symfony 6.1`
`23`	`21`	`*/`
`24`		`-class SwitchUserTokenProcessor extends AbstractTokenProcessor`
	`22`	`+final class SwitchUserTokenProcessor extends AbstractTokenProcessor`
`25`	`23`	`{`
`26`	`24`	`protected function getKey(): string`
`27`	`25`	`{`