feature #61065 [FrameworkBundle][WebProfilerBundle] remove XML routing configuration files (xabbuh)

nicolas-grekas · nicolas-grekas · commit 90e420aec0ca · 2025-07-08T14:20:38.000+02:00
This PR was merged into the 8.0 branch. Discussion ---------- [FrameworkBundle][WebProfilerBundle] remove XML routing configuration files | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT Commits ------- c693f3d remove XML routing configuration files
diff --git a/UPGRADE-8.0.md b/UPGRADE-8.0.md
@@ -173,6 +173,7 @@ Form
 FrameworkBundle
 ---------------
 
+ * Remove `errors.xml` and `webhook.xml` routing configuration files (use their PHP equivalent instead)
  * Remove deprecated `Symfony\Bundle\FrameworkBundle\Console\Application::add()` method in favor of `Symfony\Bundle\FrameworkBundle\Console\Application::addCommand()`
 
    *Before*
@@ -512,6 +513,11 @@ VarExporter
  * Remove `LazyGhostTrait` and `LazyProxyTrait`, use native lazy objects instead
  * Remove `ProxyHelper::generateLazyGhost()`, use native lazy objects instead
 
+WebProfilerBundle
+-----------------
+
+ * Remove `profiler.xml` and `wdt.xml` routing configuration files (use their PHP equivalent instead)
+
 Workflow
 --------
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 8.0
 ---
 
+ * Remove `errors.xml` and `webhook.xml` routing configuration files (use their PHP equivalent instead)
  * Enable the property info constructor extractor by default
  * Remove deprecated `Symfony\Bundle\FrameworkBundle\Console\Application::add()` method in favor of `Symfony\Bundle\FrameworkBundle\Console\Application::addCommand()`
  * Make `Router` class `final`
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/errors.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/errors.php
@@ -10,19 +10,8 @@
  */
 
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
-use Symfony\Component\Routing\Loader\XmlFileLoader;
 
 return function (RoutingConfigurator $routes): void {
-    foreach (debug_backtrace() as $trace) {
-        if (isset($trace['object']) && $trace['object'] instanceof XmlFileLoader && 'doImport' === $trace['function']) {
-            if (__DIR__ === dirname(realpath($trace['args'][3]))) {
-                trigger_deprecation('symfony/routing', '7.3', 'The "errors.xml" routing configuration file is deprecated, import "errors.php" instead.');
-
-                break;
-            }
-        }
-    }
-
     $routes->add('_preview_error', '/{code}.{_format}')
         ->controller('error_controller::preview')
         ->defaults(['_format' => 'html'])
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/errors.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/errors.xml
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/webhook.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/webhook.php
@@ -10,19 +10,8 @@
  */
 
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
-use Symfony\Component\Routing\Loader\XmlFileLoader;
 
 return function (RoutingConfigurator $routes): void {
-    foreach (debug_backtrace() as $trace) {
-        if (isset($trace['object']) && $trace['object'] instanceof XmlFileLoader && 'doImport' === $trace['function']) {
-            if (__DIR__ === dirname(realpath($trace['args'][3]))) {
-                trigger_deprecation('symfony/routing', '7.3', 'The "webhook.xml" routing configuration file is deprecated, import "webhook.php" instead.');
-
-                break;
-            }
-        }
-    }
-
     $routes->add('_webhook_controller', '/{type}')
         ->controller('webhook.controller::handle')
         ->requirements(['type' => '.+'])
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/webhook.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/routing/webhook.xml
diff --git a/src/Symfony/Bundle/WebProfilerBundle/CHANGELOG.md b/src/Symfony/Bundle/WebProfilerBundle/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+8.0
+---
+
+ * Remove `profiler.xml` and `wdt.xml` routing configuration files (use their PHP equivalent instead)
+
 7.3
 ---
 
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/profiler.php b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/profiler.php
@@ -10,19 +10,8 @@
  */
 
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
-use Symfony\Component\Routing\Loader\XmlFileLoader;
 
 return function (RoutingConfigurator $routes): void {
-    foreach (debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT) as $trace) {
-        if (isset($trace['object']) && $trace['object'] instanceof XmlFileLoader && 'doImport' === $trace['function']) {
-            if (__DIR__ === dirname(realpath($trace['args'][3]))) {
-                trigger_deprecation('symfony/routing', '7.3', 'The "profiler.xml" routing configuration file is deprecated, import "profiler.php" instead.');
-
-                break;
-            }
-        }
-    }
-
     $routes->add('_profiler_home', '/')
         ->controller('web_profiler.controller.profiler::homeAction')
     ;
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/profiler.xml b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/profiler.xml
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.php b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.php
@@ -10,19 +10,8 @@
  */
 
 use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
-use Symfony\Component\Routing\Loader\XmlFileLoader;
 
 return function (RoutingConfigurator $routes): void {
-    foreach (debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT) as $trace) {
-        if (isset($trace['object']) && $trace['object'] instanceof XmlFileLoader && 'doImport' === $trace['function']) {
-            if (__DIR__ === dirname(realpath($trace['args'][3]))) {
-                trigger_deprecation('symfony/routing', '7.3', 'The "wdt.xml" routing configuration file is deprecated, import "wdt.php" instead.');
-
-                break;
-            }
-        }
-    }
-
     $routes->add('_wdt_stylesheet', '/styles')
         ->controller('web_profiler.controller.profiler::toolbarStylesheetAction')
     ;
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.xml b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.xml
diff --git a/src/Symfony/Bundle/WebProfilerBundle/composer.json b/src/Symfony/Bundle/WebProfilerBundle/composer.json
@@ -19,7 +19,6 @@
         "php": ">=8.4",
         "composer-runtime-api": ">=2.1",
         "symfony/config": "^7.4|^8.0",
-        "symfony/deprecation-contracts": "^2.5|^3",
         "symfony/framework-bundle": "^7.4|^8.0",
         "symfony/http-kernel": "^7.4|^8.0",
         "symfony/routing": "^7.4|^8.0",
