minor #39920 [Console] Fix console logger according to PSR-3 (alex-dev)

jderusse · jderusse · commit 945c7c590c5c · 2021-01-28T23:01:20.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Fix console logger according to PSR-3 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #39050, #29138 | License | MIT `Symfony\Component\HttpKernel\EventListener\ErrorListener` logs non-HTTP exceptions at `LogLevel::CRITICAL`. `Symfony\Component\Messenger\Worker` logs unrecoverable exceptions at `LogLevel::CRITICAL`. `Symfony\Component\Console\EventListener\ErrorListener` logs exceptions at `LogLevel::ERROR`. As per PSR-3, unexpected and unrecoverable exceptions should be logged at `LogLevel::CRITICAL`. Commits ------- 69fcd07 Fix console logger according to PSR-3
diff --git a/src/Symfony/Component/Console/EventListener/ErrorListener.php b/src/Symfony/Component/Console/EventListener/ErrorListener.php
@@ -40,12 +40,12 @@ public function onConsoleError(ConsoleErrorEvent $event)
         $error = $event->getError();
 
         if (!$inputString = $this->getInputString($event)) {
-            $this->logger->error('An error occurred while using the console. Message: "{message}"', ['exception' => $error, 'message' => $error->getMessage()]);
+            $this->logger->critical('An error occurred while using the console. Message: "{message}"', ['exception' => $error, 'message' => $error->getMessage()]);
 
             return;
         }
 
-        $this->logger->error('Error thrown while running command "{command}". Message: "{message}"', ['exception' => $error, 'command' => $inputString, 'message' => $error->getMessage()]);
+        $this->logger->critical('Error thrown while running command "{command}". Message: "{message}"', ['exception' => $error, 'command' => $inputString, 'message' => $error->getMessage()]);
     }
 
     public function onConsoleTerminate(ConsoleTerminateEvent $event)
diff --git a/src/Symfony/Component/Console/Tests/EventListener/ErrorListenerTest.php b/src/Symfony/Component/Console/Tests/EventListener/ErrorListenerTest.php
@@ -33,7 +33,7 @@ public function testOnConsoleError()
         $logger = $this->createMock(LoggerInterface::class);
         $logger
             ->expects($this->once())
-            ->method('error')
+            ->method('critical')
             ->with('Error thrown while running command "{command}". Message: "{message}"', ['exception' => $error, 'command' => 'test:run --foo=baz buzz', 'message' => 'An error occurred'])
         ;
 
@@ -48,7 +48,7 @@ public function testOnConsoleErrorWithNoCommandAndNoInputString()
         $logger = $this->createMock(LoggerInterface::class);
         $logger
             ->expects($this->once())
-            ->method('error')
+            ->method('critical')
             ->with('An error occurred while using the console. Message: "{message}"', ['exception' => $error, 'message' => 'An error occurred'])
         ;
 

Original file line number	Diff line number	Diff line change
`@@ -40,12 +40,12 @@ public function onConsoleError(ConsoleErrorEvent $event)`
`40`	`40`	`$error = $event->getError();`
`41`	`41`
`42`	`42`	`if (!$inputString = $this->getInputString($event)) {`
`43`		`- $this->logger->error('An error occurred while using the console. Message: "{message}"', ['exception' => $error, 'message' => $error->getMessage()]);`
	`43`	`+ $this->logger->critical('An error occurred while using the console. Message: "{message}"', ['exception' => $error, 'message' => $error->getMessage()]);`
`44`	`44`
`45`	`45`	`return;`
`46`	`46`	`}`
`47`	`47`
`48`		`- $this->logger->error('Error thrown while running command "{command}". Message: "{message}"', ['exception' => $error, 'command' => $inputString, 'message' => $error->getMessage()]);`
	`48`	`+ $this->logger->critical('Error thrown while running command "{command}". Message: "{message}"', ['exception' => $error, 'command' => $inputString, 'message' => $error->getMessage()]);`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`public function onConsoleTerminate(ConsoleTerminateEvent $event)`