symfony/mime does not allow to add some headers as a strings, only as arrays

Oipnet · Oipnet · commit 96d7ef0f5462 · 2023-09-08T09:01:49.000Z
diff --git a/src/Symfony/Component/Mime/Header/Headers.php b/src/Symfony/Component/Mime/Header/Headers.php
@@ -147,6 +147,8 @@ public function addHeader(string $name, mixed $argument, array $more = []): stat
             $method = 'addTextHeader';
         } elseif ('addIdentificationHeader' === $method) {
             $method = 'addIdHeader';
+        } elseif ($method === 'addMailboxListHeader' && !\is_array($argument)) {
+            $argument = [$argument];
         }
 
         return $this->$method($name, $argument, $more);
diff --git a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php
@@ -69,6 +69,7 @@ public function testAddHeader()
     {
         $headers = new Headers();
         $headers->addHeader('from', ['from@example.com']);
+        $headers->addHeader('reply-to', 'reply@example.com');
         $headers->addHeader('return-path', 'return@example.com');
         $headers->addHeader('foo', 'bar');
         $headers->addHeader('date', $now = new \DateTimeImmutable());
@@ -77,6 +78,9 @@ public function testAddHeader()
         $this->assertInstanceOf(MailboxListHeader::class, $headers->get('from'));
         $this->assertEquals([new Address('from@example.com')], $headers->get('from')->getBody());
 
+        $this->assertInstanceOf(MailboxListHeader::class, $headers->get('reply-to'));
+        $this->assertEquals([new Address('reply@example.com')], $headers->get('reply-to')->getBody());
+
         $this->assertInstanceOf(PathHeader::class, $headers->get('return-path'));
         $this->assertEquals(new Address('return@example.com'), $headers->get('return-path')->getBody());
 

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,8 @@ public function addHeader(string $name, mixed $argument, array $more = []): stat`
`147`	`147`	`$method = 'addTextHeader';`
`148`	`148`	`} elseif ('addIdentificationHeader' === $method) {`
`149`	`149`	`$method = 'addIdHeader';`
	`150`	`+ } elseif ($method === 'addMailboxListHeader' && !\is_array($argument)) {`
	`151`	`+ $argument = [$argument];`
`150`	`152`	`}`
`151`	`153`
`152`	`154`	`return $this->$method($name, $argument, $more);`