bug #35113 [VarDumper] Fix "Undefined index: argv" when using CliContextProvider (xepozz)

nicolas-grekas · nicolas-grekas · commit 9876de2a289d · 2019-12-28T15:52:21.000+01:00
This PR was submitted for the master branch but it was merged into the 4.3 branch instead. Discussion ---------- [VarDumper] Fix "Undefined index: argv" when using CliContextProvider | Q | A | ------------- | --- | Branch? | 4.1, 4.2, 4.3, 4.4 or 5.0 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #35084 | License | MIT  Commits ------- 340bb14 Fixed #35084
diff --git a/src/Symfony/Component/VarDumper/Dumper/ContextProvider/CliContextProvider.php b/src/Symfony/Component/VarDumper/Dumper/ContextProvider/CliContextProvider.php
@@ -25,7 +25,7 @@ public function getContext(): ?array
         }
 
         return [
-            'command_line' => $commandLine = implode(' ', $_SERVER['argv']),
+            'command_line' => $commandLine = implode(' ', $_SERVER['argv'] ?? []),
             'identifier' => hash('crc32b', $commandLine.$_SERVER['REQUEST_TIME_FLOAT']),
         ];
     }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function getContext(): ?array`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`return [`
`28`		`- 'command_line' => $commandLine = implode(' ', $_SERVER['argv']),`
	`28`	`+ 'command_line' => $commandLine = implode(' ', $_SERVER['argv'] ?? []),`
`29`	`29`	`'identifier' => hash('crc32b', $commandLine.$_SERVER['REQUEST_TIME_FLOAT']),`
`30`	`30`	`];`
`31`	`31`	`}`