bug #54487 [Validator] Accept Stringable in ExecutionContext::build/addViolation() (alexandre-daubois)

fabpot · fabpot · commit 9c4adba8beac · 2024-04-05T08:01:35.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Validator] Accept `Stringable` in `ExecutionContext::build/addViolation()` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony-docs#19704 | License | MIT `ConstraintViolationBuilder` accepts any stringable. We mentioned this [in the doc](https://symfony.com/doc/6.4/validation/translations.html) but it doesn't work as explained in the issue. I think `buildViolation()` could accept stringable, also given that `ExecutionContextInterface` defines the type as `string|Stringable` in the PHPDoc. Same for `addViolation()`. Commits ------- 394b514 [Validator] Accept `Stringable` in `ExecutionContext::build/addViolation()`
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContext.php b/src/Symfony/Component/Validator/Context/ExecutionContext.php
@@ -139,7 +139,7 @@ public function setConstraint(Constraint $constraint): void
         $this->constraint = $constraint;
     }
 
-    public function addViolation(string $message, array $parameters = []): void
+    public function addViolation(string|\Stringable $message, array $parameters = []): void
     {
         $this->violations->add(new ConstraintViolation(
             $this->translator->trans($message, $parameters, $this->translationDomain),
@@ -154,7 +154,7 @@ public function addViolation(string $message, array $parameters = []): void
         ));
     }
 
-    public function buildViolation(string $message, array $parameters = []): ConstraintViolationBuilderInterface
+    public function buildViolation(string|\Stringable $message, array $parameters = []): ConstraintViolationBuilderInterface
     {
         return new ConstraintViolationBuilder(
             $this->violations,

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function setConstraint(Constraint $constraint): void`
`139`	`139`	`$this->constraint = $constraint;`
`140`	`140`	`}`
`141`	`141`
`142`		`- public function addViolation(string $message, array $parameters = []): void`
	`142`	`+ public function addViolation(string\|\Stringable $message, array $parameters = []): void`
`143`	`143`	`{`
`144`	`144`	`$this->violations->add(new ConstraintViolation(`
`145`	`145`	`$this->translator->trans($message, $parameters, $this->translationDomain),`
`@@ -154,7 +154,7 @@ public function addViolation(string $message, array $parameters = []): void`
`154`	`154`	`));`
`155`	`155`	`}`
`156`	`156`
`157`		`- public function buildViolation(string $message, array $parameters = []): ConstraintViolationBuilderInterface`
	`157`	`+ public function buildViolation(string\|\Stringable $message, array $parameters = []): ConstraintViolationBuilderInterface`
`158`	`158`	`{`
`159`	`159`	`return new ConstraintViolationBuilder(`
`160`	`160`	`$this->violations,`