minor #53587 [Security] fix tests (xabbuh)

xabbuh · xabbuh · commit 9d45d95b566f · 2024-01-19T15:14:57.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Security] fix tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT spotted while merging #53509 up where we added return types to the `AuthenticationUtils` methods Commits ------- c78f3e1 fix tests
diff --git a/src/Symfony/Component/Security/Http/Tests/Authentication/AuthenticationUtilsTest.php b/src/Symfony/Component/Security/Http/Tests/Authentication/AuthenticationUtilsTest.php
@@ -16,52 +16,58 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
+use Symfony\Component\Security\Core\Exception\AuthenticationException;
 use Symfony\Component\Security\Core\Security;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
 
 class AuthenticationUtilsTest extends TestCase
 {
     public function testLastAuthenticationErrorWhenRequestHasAttribute()
     {
+        $authenticationError = new AuthenticationException();
         $request = Request::create('/');
-        $request->attributes->set(Security::AUTHENTICATION_ERROR, 'my error');
+        $request->attributes->set(Security::AUTHENTICATION_ERROR, $authenticationError);
 
         $requestStack = new RequestStack();
         $requestStack->push($request);
 
         $utils = new AuthenticationUtils($requestStack);
-        $this->assertSame('my error', $utils->getLastAuthenticationError());
+        $this->assertSame($authenticationError, $utils->getLastAuthenticationError());
     }
 
     public function testLastAuthenticationErrorInSession()
     {
+        $authenticationError = new AuthenticationException();
+
         $request = Request::create('/');
 
         $session = new Session(new MockArraySessionStorage());
-        $session->set(Security::AUTHENTICATION_ERROR, 'session error');
+        $session->set(Security::AUTHENTICATION_ERROR, $authenticationError);
         $request->setSession($session);
 
         $requestStack = new RequestStack();
         $requestStack->push($request);
 
         $utils = new AuthenticationUtils($requestStack);
-        $this->assertSame('session error', $utils->getLastAuthenticationError());
+        $this->assertSame($authenticationError, $utils->getLastAuthenticationError());
         $this->assertFalse($session->has(Security::AUTHENTICATION_ERROR));
     }
 
     public function testLastAuthenticationErrorInSessionWithoutClearing()
     {
+        $authenticationError = new AuthenticationException();
+
         $request = Request::create('/');
 
         $session = new Session(new MockArraySessionStorage());
-        $session->set(Security::AUTHENTICATION_ERROR, 'session error');
+        $session->set(Security::AUTHENTICATION_ERROR, $authenticationError);
         $request->setSession($session);
 
         $requestStack = new RequestStack();
         $requestStack->push($request);
 
         $utils = new AuthenticationUtils($requestStack);
-        $this->assertSame('session error', $utils->getLastAuthenticationError(false));
+        $this->assertSame($authenticationError, $utils->getLastAuthenticationError(false));
         $this->assertTrue($session->has(Security::AUTHENTICATION_ERROR));
     }
 
