bug #52864 [HttpClient][Mailer][Process] always pass microseconds to usleep as integers (xabbuh)

derrabus · derrabus · commit a0e10fd28a62 · 2023-12-02T11:16:10.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient][Mailer][Process] always pass microseconds to usleep as integers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52856 | License | MIT Commits ------- fb0ef06 always pass microseconds to usleep as integers
diff --git a/src/Symfony/Component/HttpClient/Response/AsyncContext.php b/src/Symfony/Component/HttpClient/Response/AsyncContext.php
@@ -92,7 +92,7 @@ public function pause(float $duration): void
         if (\is_callable($pause = $this->response->getInfo('pause_handler'))) {
             $pause($duration);
         } elseif (0 < $duration) {
-            usleep(1E6 * $duration);
+            usleep((int) (1E6 * $duration));
         }
     }
 
diff --git a/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php b/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php
@@ -303,7 +303,7 @@ public static function stream(iterable $responses, float $timeout = null): \Gene
             }
 
             if (-1 === self::select($multi, min($timeoutMin, $timeoutMax - $elapsedTimeout))) {
-                usleep(min(500, 1E6 * $timeoutMin));
+                usleep((int) min(500, 1E6 * $timeoutMin));
             }
 
             $elapsedTimeout = microtime(true) - $lastActivity;
diff --git a/src/Symfony/Component/Mailer/Transport/AbstractTransport.php b/src/Symfony/Component/Mailer/Transport/AbstractTransport.php
@@ -104,7 +104,7 @@ private function checkThrottling()
         $sleep = (1 / $this->rate) - (microtime(true) - $this->lastSent);
         if (0 < $sleep) {
             $this->logger->debug(sprintf('Email transport "%s" sleeps for %.2f seconds', __CLASS__, $sleep));
-            usleep($sleep * 1000000);
+            usleep((int) ($sleep * 1000000));
         }
         $this->lastSent = microtime(true);
     }
diff --git a/src/Symfony/Component/Process/Pipes/WindowsPipes.php b/src/Symfony/Component/Process/Pipes/WindowsPipes.php
@@ -149,7 +149,7 @@ public function readAndWrite(bool $blocking, bool $close = false): array
             if ($w) {
                 @stream_select($r, $w, $e, 0, Process::TIMEOUT_PRECISION * 1E6);
             } elseif ($this->fileHandles) {
-                usleep(Process::TIMEOUT_PRECISION * 1E6);
+                usleep((int) (Process::TIMEOUT_PRECISION * 1E6));
             }
         }
         foreach ($this->fileHandles as $type => $fileHandle) {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function pause(float $duration): void`
`92`	`92`	`if (\is_callable($pause = $this->response->getInfo('pause_handler'))) {`
`93`	`93`	`$pause($duration);`
`94`	`94`	`} elseif (0 < $duration) {`
`95`		`- usleep(1E6 * $duration);`
	`95`	`+ usleep((int) (1E6 * $duration));`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ public static function stream(iterable $responses, float $timeout = null): \Gene`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`if (-1 === self::select($multi, min($timeoutMin, $timeoutMax - $elapsedTimeout))) {`
`306`		`- usleep(min(500, 1E6 * $timeoutMin));`
	`306`	`+ usleep((int) min(500, 1E6 * $timeoutMin));`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`$elapsedTimeout = microtime(true) - $lastActivity;`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ private function checkThrottling()`
`104`	`104`	`$sleep = (1 / $this->rate) - (microtime(true) - $this->lastSent);`
`105`	`105`	`if (0 < $sleep) {`
`106`	`106`	`$this->logger->debug(sprintf('Email transport "%s" sleeps for %.2f seconds', __CLASS__, $sleep));`
`107`		`- usleep($sleep * 1000000);`
	`107`	`+ usleep((int) ($sleep * 1000000));`
`108`	`108`	`}`
`109`	`109`	`$this->lastSent = microtime(true);`
`110`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ public function readAndWrite(bool $blocking, bool $close = false): array`
`149`	`149`	`if ($w) {`
`150`	`150`	`@stream_select($r, $w, $e, 0, Process::TIMEOUT_PRECISION * 1E6);`
`151`	`151`	`} elseif ($this->fileHandles) {`
`152`		`- usleep(Process::TIMEOUT_PRECISION * 1E6);`
	`152`	`+ usleep((int) (Process::TIMEOUT_PRECISION * 1E6));`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`	`foreach ($this->fileHandles as $type => $fileHandle) {`