Definition::addMethodCall() arg 3 must be a bool v2

Girgias · Girgias · commit a249be4b3b64 · 2025-06-25T14:23:14.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php
@@ -70,7 +70,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed
             $setters = $value->getMethodCalls();
             $value->setMethodCalls($withers);
             foreach ($setters as $call) {
-                $value->addMethodCall($call[0], $call[1], $call[2] ?? false);
+                $value->addMethodCall($call[0], $call[1], isset($call[2]));
             }
         }
 
diff --git a/src/Symfony/Component/DependencyInjection/Definition.php b/src/Symfony/Component/DependencyInjection/Definition.php
@@ -307,7 +307,7 @@ public function setMethodCalls(array $calls = []): static
     {
         $this->calls = [];
         foreach ($calls as $call) {
-            $this->addMethodCall($call[0], $call[1], $call[2] ?? false);
+            $this->addMethodCall($call[0], $call[1], isset($call[2]));
         }
 
         return $this;
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -339,7 +339,11 @@ private function parseDefinition(\DOMElement $service, string $file, Definition
         }
 
         foreach ($this->getChildren($service, 'call') as $call) {
-            $definition->addMethodCall($call->getAttribute('method'), $this->getArgumentsAsPhp($call, 'argument', $file), XmlUtils::phpize($call->getAttribute('returns-clone')));
+            $definition->addMethodCall(
+                $call->getAttribute('method'),
+                $this->getArgumentsAsPhp($call, 'argument', $file),
+                (bool) XmlUtils::phpize($call->getAttribute('returns-clone'))
+            );
         }
 
         $tags = $this->getChildren($service, 'tag');
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -568,7 +568,7 @@ private function parseDefinition(string $id, array|string|null $service, string
                 if (isset($call['method']) && \is_string($call['method'])) {
                     $method = $call['method'];
                     $args = $call['arguments'] ?? [];
-                    $returnsClone = $call['returns_clone'] ?? false;
+                    $returnsClone = isset($call['returns_clone']);
                 } else {
                     if (1 === \count($call) && \is_string(key($call))) {
                         $method = key($call);
@@ -589,7 +589,7 @@ private function parseDefinition(string $id, array|string|null $service, string
                     } else {
                         $method = $call[0];
                         $args = $call[1] ?? [];
-                        $returnsClone = $call[2] ?? false;
+                        $returnsClone = isset($call[2]);
                     }
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ protected function processValue(mixed $value, bool $isRoot = false): mixed`
`70`	`70`	`$setters = $value->getMethodCalls();`
`71`	`71`	`$value->setMethodCalls($withers);`
`72`	`72`	`foreach ($setters as $call) {`
`73`		`- $value->addMethodCall($call[0], $call[1], $call[2] ?? false);`
	`73`	`+ $value->addMethodCall($call[0], $call[1], isset($call[2]));`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ public function setMethodCalls(array $calls = []): static`
`307`	`307`	`{`
`308`	`308`	`$this->calls = [];`
`309`	`309`	`foreach ($calls as $call) {`
`310`		`- $this->addMethodCall($call[0], $call[1], $call[2] ?? false);`
	`310`	`+ $this->addMethodCall($call[0], $call[1], isset($call[2]));`
`311`	`311`	`}`
`312`	`312`
`313`	`313`	`return $this;`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,11 @@ private function parseDefinition(\DOMElement $service, string $file, Definition`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`foreach ($this->getChildren($service, 'call') as $call) {`
`342`		`- $definition->addMethodCall($call->getAttribute('method'), $this->getArgumentsAsPhp($call, 'argument', $file), XmlUtils::phpize($call->getAttribute('returns-clone')));`
	`342`	`+ $definition->addMethodCall(`
	`343`	`+ $call->getAttribute('method'),`
	`344`	`+ $this->getArgumentsAsPhp($call, 'argument', $file),`
	`345`	`+ (bool) XmlUtils::phpize($call->getAttribute('returns-clone'))`
	`346`	`+ );`
`343`	`347`	`}`
`344`	`348`
`345`	`349`	`$tags = $this->getChildren($service, 'tag');`