bug #34957 [Security] Revert "AbstractAuthenticationListener.php error instead info" (larzuk91)

nicolas-grekas · nicolas-grekas · commit a24b16534ea7 · 2019-12-13T13:11:54.000+01:00
This PR was submitted for the master branch but it was merged into the 4.4 branch instead. Discussion ---------- [Security] Revert "AbstractAuthenticationListener.php error instead info" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34836 | License | MIT This reverts commit 867eb78. After that change, every failed login attempt is logged as an error. It's flooding our errors log channel Commits ------- 9d306f9 [SECURITY] Revert "AbstractAuthenticationListener.php error instead info. Rebase of #28462"
diff --git a/src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php b/src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
@@ -184,7 +184,7 @@ abstract protected function attemptAuthentication(Request $request);
     private function onFailure(Request $request, AuthenticationException $failed): Response
     {
         if (null !== $this->logger) {
-            $this->logger->error('Authentication request failed.', ['exception' => $failed]);
+            $this->logger->info('Authentication request failed.', ['exception' => $failed]);
         }
 
         $token = $this->tokenStorage->getToken();

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ abstract protected function attemptAuthentication(Request $request);`
`184`	`184`	`private function onFailure(Request $request, AuthenticationException $failed): Response`
`185`	`185`	`{`
`186`	`186`	`if (null !== $this->logger) {`
`187`		`- $this->logger->error('Authentication request failed.', ['exception' => $failed]);`
	`187`	`+ $this->logger->info('Authentication request failed.', ['exception' => $failed]);`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`$token = $this->tokenStorage->getToken();`