add parameter type declarations where possible

xabbuh · xabbuh · commit a589e2bbe437 · 2019-07-27T12:14:41.000+02:00
diff --git a/src/Symfony/Bridge/Twig/Command/LintCommand.php b/src/Symfony/Bridge/Twig/Command/LintCommand.php
@@ -107,7 +107,7 @@ private function getFilesInfo(array $filenames)
         return $filesInfo;
     }
 
-    protected function findFiles($filename)
+    protected function findFiles(string $filename)
     {
         if (is_file($filename)) {
             return [$filename];
diff --git a/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCacheWarmer.php b/src/Symfony/Bundle/TwigBundle/CacheWarmer/TemplateCacheWarmer.php
@@ -38,7 +38,7 @@ public function __construct(ContainerInterface $container, iterable $iterator)
     /**
      * {@inheritdoc}
      */
-    public function warmUp($cacheDir)
+    public function warmUp(string $cacheDir)
     {
         if (null === $this->twig) {
             $this->twig = $this->container->get('twig');
diff --git a/src/Symfony/Bundle/TwigBundle/Command/LintCommand.php b/src/Symfony/Bundle/TwigBundle/Command/LintCommand.php
@@ -42,7 +42,7 @@ protected function configure()
         ;
     }
 
-    protected function findFiles($filename)
+    protected function findFiles(string $filename)
     {
         if (0 === strpos($filename, '@')) {
             $dir = $this->getApplication()->getKernel()->locateResource($filename);
diff --git a/src/Symfony/Bundle/TwigBundle/Controller/PreviewErrorController.php b/src/Symfony/Bundle/TwigBundle/Controller/PreviewErrorController.php
@@ -37,7 +37,7 @@ public function __construct(HttpKernelInterface $kernel, $controller, ErrorRende
         $this->errorRenderer = $errorRenderer;
     }
 
-    public function previewErrorPageAction(Request $request, $code)
+    public function previewErrorPageAction(Request $request, int $code)
     {
         $exception = FlattenException::createFromThrowable(new \Exception('Something has intentionally gone wrong.'), $code, ['X-Debug' => false]);
 
diff --git a/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php b/src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
@@ -170,7 +170,7 @@ private function getBundleTemplatePaths(ContainerBuilder $container, array $conf
         return $bundleHierarchy;
     }
 
-    private function normalizeBundleName($name)
+    private function normalizeBundleName(string $name)
     {
         if ('Bundle' === substr($name, -6)) {
             $name = substr($name, 0, -6);
diff --git a/src/Symfony/Bundle/TwigBundle/composer.json b/src/Symfony/Bundle/TwigBundle/composer.json
@@ -19,9 +19,9 @@
         "php": "^7.2.9",
         "symfony/config": "^4.4|^5.0",
         "symfony/error-renderer": "^4.4|^5.0",
-        "symfony/twig-bridge": "^4.4|^5.0",
+        "symfony/twig-bridge": "^5.0",
         "symfony/http-foundation": "^4.4|^5.0",
-        "symfony/http-kernel": "^4.4|^5.0",
+        "symfony/http-kernel": "^5.0",
         "symfony/polyfill-ctype": "~1.8",
         "twig/twig": "^2.10"
     },

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ private function getFilesInfo(array $filenames)`
`107`	`107`	`return $filesInfo;`
`108`	`108`	`}`
`109`	`109`
`110`		`- protected function findFiles($filename)`
	`110`	`+ protected function findFiles(string $filename)`
`111`	`111`	`{`
`112`	`112`	`if (is_file($filename)) {`
`113`	`113`	`return [$filename];`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function __construct(ContainerInterface $container, iterable $iterator)`
`38`	`38`	`/**`
`39`	`39`	`* {@inheritdoc}`
`40`	`40`	`*/`
`41`		`- public function warmUp($cacheDir)`
	`41`	`+ public function warmUp(string $cacheDir)`
`42`	`42`	`{`
`43`	`43`	`if (null === $this->twig) {`
`44`	`44`	`$this->twig = $this->container->get('twig');`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected function configure()`
`42`	`42`	`;`
`43`	`43`	`}`
`44`	`44`
`45`		`- protected function findFiles($filename)`
	`45`	`+ protected function findFiles(string $filename)`
`46`	`46`	`{`
`47`	`47`	`if (0 === strpos($filename, '@')) {`
`48`	`48`	`$dir = $this->getApplication()->getKernel()->locateResource($filename);`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function __construct(HttpKernelInterface $kernel, $controller, ErrorRende`
`37`	`37`	`$this->errorRenderer = $errorRenderer;`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function previewErrorPageAction(Request $request, $code)`
	`40`	`+ public function previewErrorPageAction(Request $request, int $code)`
`41`	`41`	`{`
`42`	`42`	`$exception = FlattenException::createFromThrowable(new \Exception('Something has intentionally gone wrong.'), $code, ['X-Debug' => false]);`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ private function getBundleTemplatePaths(ContainerBuilder $container, array $conf`
`170`	`170`	`return $bundleHierarchy;`
`171`	`171`	`}`
`172`	`172`
`173`		`- private function normalizeBundleName($name)`
	`173`	`+ private function normalizeBundleName(string $name)`
`174`	`174`	`{`
`175`	`175`	`if ('Bundle' === substr($name, -6)) {`
`176`	`176`	`$name = substr($name, 0, -6);`