Added support for PHP 7.4 to PropertyNormalizer

vudaltsov · vudaltsov · commit a7e10fc2bcb0 · 2019-12-03T21:01:19.000+03:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/PropertyNormalizer.php
@@ -124,6 +124,10 @@ protected function getAttributeValue($object, $attribute, $format = null, array
             return null;
         }
 
+        if (\PHP_VERSION_ID >= 70400 && !$reflectionProperty->isInitialized($object)) {
+            return null;
+        }
+
         // Override visibility
         if (!$reflectionProperty->isPublic()) {
             $reflectionProperty->setAccessible(true);
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/Php74Dummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/Php74Dummy.php
@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Tests\Fixtures;
+
+/**
+ * @author Valentin Udaltsov <udaltsov.valentin@gmail.com>
+ */
+final class Php74Dummy
+{
+    public string $property;
+}
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php
@@ -22,6 +22,7 @@
 use Symfony\Component\Serializer\Tests\Fixtures\GroupDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\GroupDummyChild;
 use Symfony\Component\Serializer\Tests\Fixtures\MaxDepthDummy;
+use Symfony\Component\Serializer\Tests\Fixtures\Php74Dummy;
 use Symfony\Component\Serializer\Tests\Fixtures\PropertyCircularReferenceDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\PropertySiblingHolder;
 
@@ -55,6 +56,18 @@ public function testNormalize()
         );
     }
 
+    /**
+     * @requires PHP 7.4
+     */
+    public function testNormalizeUninitializedProperty()
+    {
+        $obj = new Php74Dummy();
+        $this->assertEquals(
+            ['property' => null],
+            $this->normalizer->normalize($obj, 'any')
+        );
+    }
+
     public function testDenormalize()
     {
         $obj = $this->normalizer->denormalize(
