bug #47836 [HttpClient] TraceableHttpClient: increase decorator's priority (adpeyre)

nicolas-grekas · nicolas-grekas · commit a81077242ab5 · 2022-12-13T12:07:49.000+01:00
This PR was submitted for the 4.4 branch but it was merged into the 5.4 branch instead. Discussion ---------- [HttpClient] TraceableHttpClient: increase decorator's priority | Q | A | ------------- | --- | Branch? | 4.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets |  | License | MIT | Doc PR |  Hello, When I decorate my http client, all requests are not collected and visible in the profiler because of the decorator's priority of TraceableHttpClient (sub request for example). I think it should be increased. I fixed an arbitrary value of 100. What do you think about that ? Ty Commits ------- a4e3b93 TraceableHttpClient: increase decorator's priority
diff --git a/src/Symfony/Component/HttpClient/DependencyInjection/HttpClientPass.php b/src/Symfony/Component/HttpClient/DependencyInjection/HttpClientPass.php
@@ -43,7 +43,7 @@ public function process(ContainerBuilder $container)
             $container->register('.debug.'.$id, TraceableHttpClient::class)
                 ->setArguments([new Reference('.debug.'.$id.'.inner'), new Reference('debug.stopwatch', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)])
                 ->addTag('kernel.reset', ['method' => 'reset'])
-                ->setDecoratedService($id);
+                ->setDecoratedService($id, null, 5);
             $container->getDefinition('data_collector.http_client')
                 ->addMethodCall('registerClient', [$id, new Reference('.debug.'.$id)]);
         }
diff --git a/src/Symfony/Component/HttpClient/Tests/DependencyInjection/HttpClientPassTest.php b/src/Symfony/Component/HttpClient/Tests/DependencyInjection/HttpClientPassTest.php
@@ -38,7 +38,7 @@ public function testItDecoratesHttpClientWithTraceableHttpClient()
         $sut->process($container);
         $this->assertTrue($container->hasDefinition('.debug.foo'));
         $this->assertSame(TraceableHttpClient::class, $container->getDefinition('.debug.foo')->getClass());
-        $this->assertSame(['foo', null, 0], $container->getDefinition('.debug.foo')->getDecoratedService());
+        $this->assertSame(['foo', null, 5], $container->getDefinition('.debug.foo')->getDecoratedService());
     }
 
     public function testItRegistersDebugHttpClientToCollector()

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function process(ContainerBuilder $container)`
`43`	`43`	`$container->register('.debug.'.$id, TraceableHttpClient::class)`
`44`	`44`	`->setArguments([new Reference('.debug.'.$id.'.inner'), new Reference('debug.stopwatch', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)])`
`45`	`45`	`->addTag('kernel.reset', ['method' => 'reset'])`
`46`		`- ->setDecoratedService($id);`
	`46`	`+ ->setDecoratedService($id, null, 5);`
`47`	`47`	`$container->getDefinition('data_collector.http_client')`
`48`	`48`	`->addMethodCall('registerClient', [$id, new Reference('.debug.'.$id)]);`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function testItDecoratesHttpClientWithTraceableHttpClient()`
`38`	`38`	`$sut->process($container);`
`39`	`39`	`$this->assertTrue($container->hasDefinition('.debug.foo'));`
`40`	`40`	`$this->assertSame(TraceableHttpClient::class, $container->getDefinition('.debug.foo')->getClass());`
`41`		`- $this->assertSame(['foo', null, 0], $container->getDefinition('.debug.foo')->getDecoratedService());`
	`41`	`+ $this->assertSame(['foo', null, 5], $container->getDefinition('.debug.foo')->getDecoratedService());`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`public function testItRegistersDebugHttpClientToCollector()`