[Security] Return null instead of empty username to fix deprecation notice

phasdev · phasdev · commit a8516b7184f9 · 2025-01-28T19:24:43.000Z
diff --git a/src/Symfony/Component/Security/Http/Authenticator/RemoteUserAuthenticator.php b/src/Symfony/Component/Security/Http/Authenticator/RemoteUserAuthenticator.php
@@ -45,6 +45,6 @@ protected function extractUsername(Request $request): ?string
             throw new BadCredentialsException(sprintf('User key was not found: "%s".', $this->userKey));
         }
 
-        return $request->server->get($this->userKey);
+        return $request->server->get($this->userKey) ?: null;
     }
 }
diff --git a/src/Symfony/Component/Security/Http/Tests/Authenticator/RemoteUserAuthenticatorTest.php b/src/Symfony/Component/Security/Http/Tests/Authenticator/RemoteUserAuthenticatorTest.php
@@ -36,6 +36,7 @@ public function testSupportNoUser()
         $authenticator = new RemoteUserAuthenticator(new InMemoryUserProvider(), new TokenStorage(), 'main');
 
         $this->assertFalse($authenticator->supports($this->createRequest([])));
+        $this->assertFalse($authenticator->supports($this->createRequest(['REMOTE_USER' => ''])));
     }
 
     public function testSupportTokenStorageWithToken()

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@ protected function extractUsername(Request $request): ?string`
`45`	`45`	`throw new BadCredentialsException(sprintf('User key was not found: "%s".', $this->userKey));`
`46`	`46`	`}`
`47`	`47`
`48`		`- return $request->server->get($this->userKey);`
	`48`	`+ return $request->server->get($this->userKey) ?: null;`
`49`	`49`	`}`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ public function testSupportNoUser()`
`36`	`36`	`$authenticator = new RemoteUserAuthenticator(new InMemoryUserProvider(), new TokenStorage(), 'main');`
`37`	`37`
`38`	`38`	`$this->assertFalse($authenticator->supports($this->createRequest([])));`
	`39`	`+ $this->assertFalse($authenticator->supports($this->createRequest(['REMOTE_USER' => ''])));`
`39`	`40`	`}`
`40`	`41`
`41`	`42`	`public function testSupportTokenStorageWithToken()`