minor #59179 [FrameworkBundle] [JsonEncoder] Fix service definition (mtarld)

xabbuh · xabbuh · commit aa2309343ab9 · 2024-12-12T16:16:01.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [FrameworkBundle] [JsonEncoder] Fix service definition | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The `stack` makes the CI fail, therefore this PR replaces `$container->services()->stack()` by a regular service decoration. Of course, an issue must be created in order to make `stack` working in the Symfony CI. Commits ------- 0d74921 [JsonEncoder] [FrameworkBundle] Fix service definition
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/json_encoder.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/json_encoder.php
@@ -45,49 +45,51 @@
         ->alias(JsonDecoder::class, 'json_encoder.decoder')
 
         // metadata
-        ->stack('json_encoder.encode.property_metadata_loader', [
-            inline_service(EncodeAttributePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                    tagged_locator('json_encoder.normalizer'),
-                    service('type_info.resolver'),
-                ]),
-            inline_service(EncodeDateTimeTypePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                ]),
-            inline_service(GenericTypePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                    service('type_info.type_context_factory'),
-                ]),
-            inline_service(PropertyMetadataLoader::class)
-                ->args([
-                    service('type_info.resolver'),
-                ]),
-        ])
+        ->set('json_encoder.encode.property_metadata_loader', PropertyMetadataLoader::class)
+            ->args([
+                service('type_info.resolver'),
+            ])
+        ->set('.json_encoder.encode.property_metadata_loader.generic', GenericTypePropertyMetadataLoader::class)
+            ->decorate('json_encoder.encode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+                service('type_info.type_context_factory'),
+            ])
+        ->set('.json_encoder.encode.property_metadata_loader.date_time', EncodeDateTimeTypePropertyMetadataLoader::class)
+            ->decorate('json_encoder.encode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+            ])
+        ->set('.json_encoder.encode.property_metadata_loader.attribute', EncodeAttributePropertyMetadataLoader::class)
+            ->decorate('json_encoder.encode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+                tagged_locator('json_encoder.normalizer'),
+                service('type_info.resolver'),
+            ])
 
-        ->stack('json_encoder.decode.property_metadata_loader', [
-            inline_service(DecodeAttributePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                    tagged_locator('json_encoder.denormalizer'),
-                    service('type_info.resolver'),
-                ]),
-            inline_service(DecodeDateTimeTypePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                ]),
-            inline_service(GenericTypePropertyMetadataLoader::class)
-                ->args([
-                    service('.inner'),
-                    service('type_info.type_context_factory'),
-                ]),
-            inline_service(PropertyMetadataLoader::class)
-                ->args([
-                    service('type_info.resolver'),
-                ]),
-        ])
+        ->set('json_encoder.decode.property_metadata_loader', PropertyMetadataLoader::class)
+            ->args([
+                service('type_info.resolver'),
+            ])
+        ->set('.json_encoder.decode.property_metadata_loader.generic', GenericTypePropertyMetadataLoader::class)
+            ->decorate('json_encoder.decode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+                service('type_info.type_context_factory'),
+            ])
+        ->set('.json_encoder.decode.property_metadata_loader.date_time', DecodeDateTimeTypePropertyMetadataLoader::class)
+            ->decorate('json_encoder.decode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+            ])
+        ->set('.json_encoder.decode.property_metadata_loader.attribute', DecodeAttributePropertyMetadataLoader::class)
+            ->decorate('json_encoder.decode.property_metadata_loader')
+            ->args([
+                service('.inner'),
+                tagged_locator('json_encoder.normalizer'),
+                service('type_info.resolver'),
+            ])
 
         // normalizers/denormalizers
         ->set('json_encoder.normalizer.date_time', DateTimeNormalizer::class)
