applied code review suggestions

kbond · kbond · commit b008b2a48e6b · 2023-07-28T09:37:30.000-04:00
diff --git a/src/Symfony/Component/Process/Exception/RunProcessFailedException.php b/src/Symfony/Component/Process/Exception/RunProcessFailedException.php
@@ -9,10 +9,9 @@
  * file that was distributed with this source code.
  */
 
-namespace Symfony\Component\Process\Messenger;
+namespace Symfony\Component\Process\Exception;
 
-use Symfony\Component\Process\Exception\ProcessFailedException;
-use Symfony\Component\Process\Exception\RuntimeException;
+use Symfony\Component\Process\Messenger\RunProcessContext;
 
 /**
  * @author Kevin Bond <kevinbond@gmail.com>
diff --git a/src/Symfony/Component/Process/Messenger/RunProcessContext.php b/src/Symfony/Component/Process/Messenger/RunProcessContext.php
@@ -30,5 +30,4 @@ public function __construct(RunProcessMessage $message, Process $process)
         $this->output = $process->isOutputDisabled() ? null : $process->getOutput();
         $this->errorOutput = $process->isOutputDisabled() ? null : $process->getErrorOutput();
     }
-
 }
diff --git a/src/Symfony/Component/Process/Messenger/RunProcessMessage.php b/src/Symfony/Component/Process/Messenger/RunProcessMessage.php
@@ -21,7 +21,7 @@ public function __construct(
         public readonly ?string $cwd = null,
         public readonly ?array $env = null,
         public readonly mixed $input = null,
-        public readonly ?float $timeout = 60,
+        public readonly ?float $timeout = 60.0,
     ) {
     }
 
diff --git a/src/Symfony/Component/Process/Messenger/RunProcessMessageHandler.php b/src/Symfony/Component/Process/Messenger/RunProcessMessageHandler.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Process\Messenger;
 
 use Symfony\Component\Process\Exception\ProcessFailedException;
+use Symfony\Component\Process\Exception\RunProcessFailedException;
 use Symfony\Component\Process\Process;
 
 /**
diff --git a/src/Symfony/Component/Process/Tests/Messenger/RunProcessMessageHandlerTest.php b/src/Symfony/Component/Process/Tests/Messenger/RunProcessMessageHandlerTest.php
@@ -12,7 +12,7 @@
 namespace Symfony\Component\Process\Tests\Messenger;
 
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Process\Messenger\RunProcessFailedException;
+use Symfony\Component\Process\Exception\RunProcessFailedException;
 use Symfony\Component\Process\Messenger\RunProcessMessage;
 use Symfony\Component\Process\Messenger\RunProcessMessageHandler;
 

Original file line number	Diff line number	Diff line change
`@@ -30,5 +30,4 @@ public function __construct(RunProcessMessage $message, Process $process)`
`30`	`30`	`$this->output = $process->isOutputDisabled() ? null : $process->getOutput();`
`31`	`31`	`$this->errorOutput = $process->isOutputDisabled() ? null : $process->getErrorOutput();`
`32`	`32`	`}`
`33`		`-`
`34`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function __construct(`
`21`	`21`	`public readonly ?string $cwd = null,`
`22`	`22`	`public readonly ?array $env = null,`
`23`	`23`	`public readonly mixed $input = null,`
`24`		`- public readonly ?float $timeout = 60,`
	`24`	`+ public readonly ?float $timeout = 60.0,`
`25`	`25`	`) {`
`26`	`26`	`}`
`27`	`27`