[Security} Make remember-me user providers lazy

Robin Chalas · Robin Chalas · commit b27b49f4cbe8 · 2019-12-01T14:10:09.000+01:00
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php
@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory;
 
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
+use Symfony\Component\DependencyInjection\Argument\IteratorArgument;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
@@ -104,7 +105,7 @@ public function create(ContainerBuilder $container, $id, $config, $userProvider,
             throw new \RuntimeException('You must configure at least one remember-me aware listener (such as form-login) for each firewall that has remember-me enabled.');
         }
 
-        $rememberMeServices->replaceArgument(0, array_unique($userProviders));
+        $rememberMeServices->replaceArgument(0, new IteratorArgument(array_unique($userProviders)));
 
         // remember-me listener
         $listenerId = 'security.authentication.listener.rememberme.'.$id;
diff --git a/src/Symfony/Component/Security/Http/RememberMe/AbstractRememberMeServices.php b/src/Symfony/Component/Security/Http/RememberMe/AbstractRememberMeServices.php
@@ -47,7 +47,7 @@ abstract class AbstractRememberMeServices implements RememberMeServicesInterface
     /**
      * @throws \InvalidArgumentException
      */
-    public function __construct(array $userProviders, string $secret, string $providerKey, array $options = [], LoggerInterface $logger = null)
+    public function __construct(iterable $userProviders, string $secret, string $providerKey, array $options = [], LoggerInterface $logger = null)
     {
         if (empty($secret)) {
             throw new \InvalidArgumentException('$secret must not be empty.');

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ abstract class AbstractRememberMeServices implements RememberMeServicesInterface`
`47`	`47`	`/**`
`48`	`48`	`* @throws \InvalidArgumentException`
`49`	`49`	`*/`
`50`		`- public function __construct(array $userProviders, string $secret, string $providerKey, array $options = [], LoggerInterface $logger = null)`
	`50`	`+ public function __construct(iterable $userProviders, string $secret, string $providerKey, array $options = [], LoggerInterface $logger = null)`
`51`	`51`	`{`
`52`	`52`	`if (empty($secret)) {`
`53`	`53`	`throw new \InvalidArgumentException('$secret must not be empty.');`