feature #16690 [Form] Deprecated ArrayKeyChoiceList (webmozart)

fabpot · fabpot · commit b29691067db2 · 2015-11-27T10:03:43.000+01:00
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Deprecated ArrayKeyChoiceList | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 5386752 [Form] Deprecated ArrayKeyChoiceList
diff --git a/UPGRADE-2.8.md b/UPGRADE-2.8.md
@@ -251,10 +251,13 @@ Form
        <tag name="form.type_extension" extended-type="Symfony\Component\Form\Extension\Core\Type\TextType" />
    </service>
    ```
-   
+
  * The `TimezoneType::getTimezones()` method was deprecated and will be removed
    in Symfony 3.0. You should not use this method.
 
+ * The class `ArrayKeyChoiceList` was deprecated and will be removed in Symfony
+   3.0. Use `ArrayChoiceList` instead.
+
 Translator
 ----------
 
diff --git a/UPGRADE-3.0.md b/UPGRADE-3.0.md
@@ -315,6 +315,9 @@ UPGRADE FROM 2.x to 3.0
  * The `TimezoneType::getTimezones()` method was removed. You should not use 
    this method.
 
+ * The `Symfony\Component\Form\ChoiceList\ArrayKeyChoiceList` class has been removed in
+   favor of `Symfony\Component\Form\ChoiceList\ArrayChoiceList`.
+
 ### FrameworkBundle
 
  * The `config:debug`, `container:debug`, `router:debug`, `translation:debug`
diff --git a/src/Symfony/Component/Form/ChoiceList/ArrayKeyChoiceList.php b/src/Symfony/Component/Form/ChoiceList/ArrayKeyChoiceList.php
@@ -11,6 +11,8 @@
 
 namespace Symfony\Component\Form\ChoiceList;
 
+@trigger_error('The '.__NAMESPACE__.'\ArrayKeyChoiceList class is deprecated since version 2.8 and will be removed in 3.0. Use '.__NAMESPACE__.'\ArrayChoiceList instead.', E_USER_DEPRECATED);
+
 use Symfony\Component\Form\Exception\InvalidArgumentException;
 
 /**
diff --git a/src/Symfony/Component/Form/Tests/ChoiceList/ArrayKeyChoiceListTest.php b/src/Symfony/Component/Form/Tests/ChoiceList/ArrayKeyChoiceListTest.php
@@ -15,6 +15,8 @@
 
 /**
  * @author Bernhard Schussek <bschussek@gmail.com>
+ *
+ * @group legacy
  */
 class ArrayKeyChoiceListTest extends AbstractChoiceListTest
 {

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`
`16`	`16`	`/**`
`17`	`17`	`* @author Bernhard Schussek <bschussek@gmail.com>`
	`18`	`+ *`
	`19`	`+ * @group legacy`
`18`	`20`	`*/`
`19`	`21`	`class ArrayKeyChoiceListTest extends AbstractChoiceListTest`
`20`	`22`	`{`