[Config] improve perf of glob discovery when GLOB_BRACE is not available

nicolas-grekas · nicolas-grekas · commit b50c36a22e26 · 2019-12-17T19:15:35.000+01:00
diff --git a/src/Symfony/Component/Config/Resource/GlobResource.php b/src/Symfony/Component/Config/Resource/GlobResource.php
@@ -31,6 +31,7 @@ class GlobResource implements \IteratorAggregate, SelfCheckingResourceInterface
     private $hash;
     private $forExclusion;
     private $excludedPrefixes;
+    private $globBrace;
 
     /**
      * @param string $prefix    A directory prefix
@@ -47,6 +48,7 @@ public function __construct(string $prefix, string $pattern, bool $recursive, bo
         $this->recursive = $recursive;
         $this->forExclusion = $forExclusion;
         $this->excludedPrefixes = $excludedPrefixes;
+        $this->globBrace = \defined('GLOB_BRACE') ? GLOB_BRACE : 0;
 
         if (false === $this->prefix) {
             throw new \InvalidArgumentException(sprintf('The path "%s" does not exist.', $prefix));
@@ -101,9 +103,17 @@ public function getIterator()
             return;
         }
         $prefix = str_replace('\\', '/', $this->prefix);
+        $paths = null;
 
-        if (0 !== strpos($this->prefix, 'phar://') && false === strpos($this->pattern, '/**/') && (\defined('GLOB_BRACE') || false === strpos($this->pattern, '{'))) {
-            $paths = glob($this->prefix.$this->pattern, GLOB_NOSORT | (\defined('GLOB_BRACE') ? GLOB_BRACE : 0));
+        if (0 !== strpos($this->prefix, 'phar://') && false === strpos($this->pattern, '/**/')) {
+            if ($this->globBrace || false === strpos($this->pattern, '{')) {
+                $paths = glob($this->prefix.$this->pattern, GLOB_NOSORT | $this->globBrace);
+            } elseif (false === strpos($this->pattern, '\\')) {
+                $paths = $this->fallbackGlob();
+            }
+        }
+
+        if (null !== $paths) {
             sort($paths);
             foreach ($paths as $path) {
                 if ($this->excludedPrefixes) {
@@ -187,4 +197,32 @@ private function computeHash(): string
 
         return hash_final($hash);
     }
+
+    private function fallbackGlob(): ?array
+    {
+        $segments = preg_split('/\{([^{}]*+)\}/', $this->pattern, -1, PREG_SPLIT_DELIM_CAPTURE);
+        $paths = [$segments[0]];
+
+        for ($i = 1; $i < \count($segments); $i += 2) {
+            $patterns = [];
+
+            foreach (explode(',', $segments[$i]) as $s) {
+                foreach ($paths as $p) {
+                    $patterns[] = $p.$s.$segments[1 + $i];
+                }
+            }
+
+            $paths = $patterns;
+        }
+
+        foreach ($paths as $i => $p) {
+            if (false !== strpos($p, '{') || false !== strpos($p, '}')) {
+                return null;
+            }
+
+            $paths[$i] = glob($this->prefix.$p, GLOB_NOSORT);
+        }
+
+        return array_merge(...$paths);
+    }
 }
diff --git a/src/Symfony/Component/Config/Tests/Resource/GlobResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/GlobResourceTest.php
@@ -165,4 +165,21 @@ public function testIsFreshRecursiveDetectsNewFile()
         touch($dir.'/Resource/TmpGlob');
         $this->assertFalse($resource->isFresh(0));
     }
+
+    public function testBraceFallback()
+    {
+        $dir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures';
+        $resource = new GlobResource($dir, '/*{/*/*.txt,.xml}', true);
+
+        $p = new \ReflectionProperty($resource, 'globBrace');
+        $p->setAccessible(true);
+        $p->setValue($resource, 0);
+
+        $expected = [
+            $dir.'/Exclude/ExcludeToo/AnotheExcludedFile.txt',
+            $dir.'/foo.xml',
+        ];
+
+        $this->assertSame($expected, array_keys(iterator_to_array($resource)));
+    }
 }
