minor #18906 [PropertyAccess] Fix for PHP 7.0.7 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit b576fe1b8527 · 2016-05-29T11:47:26.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [PropertyAccess] Fix for PHP 7.0.7 | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is what break travis currently. See https://3v4l.org/r37rY Commits ------- a125af7 [PropertyAccess] Fix for PHP 7.0.7
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCollectionTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorCollectionTest.php
@@ -173,7 +173,9 @@ public function testSetValueUpdatesNestedArrayAccess()
      */
     public function testSetValueThrowsExceptionIfArrayAccessExpected()
     {
-        $this->propertyAccessor->setValue(new \stdClass(), '[firstName]', 'Bernhard');
+        $object = new \stdClass();
+
+        $this->propertyAccessor->setValue($object, '[firstName]', 'Bernhard');
     }
 
     public function testSetValueCallsAdderAndRemoverForCollections()
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -311,7 +311,9 @@ public function testSetValueCamelizesSetterNames()
      */
     public function testSetValueThrowsExceptionIfGetterIsNotPublic()
     {
-        $this->propertyAccessor->setValue(new Author(), 'privateSetter', 'foobar');
+        $object = new Author();
+
+        $this->propertyAccessor->setValue($object, 'privateSetter', 'foobar');
     }
 
     /**
@@ -414,7 +416,9 @@ public function getValidPropertyPaths()
      */
     public function testThrowTypeError()
     {
-        $this->propertyAccessor->setValue(new TypeHinted(), 'date', 'This is a string, \DateTime expected.');
+        $object = new TypeHinted();
+
+        $this->propertyAccessor->setValue($object, 'date', 'This is a string, \DateTime expected.');
     }
 
     public function testSetTypeHint()

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,9 @@ public function testSetValueUpdatesNestedArrayAccess()`
`173`	`173`	`*/`
`174`	`174`	`public function testSetValueThrowsExceptionIfArrayAccessExpected()`
`175`	`175`	`{`
`176`		`- $this->propertyAccessor->setValue(new \stdClass(), '[firstName]', 'Bernhard');`
	`176`	`+ $object = new \stdClass();`
	`177`	`+`
	`178`	`+ $this->propertyAccessor->setValue($object, '[firstName]', 'Bernhard');`
`177`	`179`	`}`
`178`	`180`
`179`	`181`	`public function testSetValueCallsAdderAndRemoverForCollections()`
Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,9 @@ public function testSetValueCamelizesSetterNames()`
`311`	`311`	`*/`
`312`	`312`	`public function testSetValueThrowsExceptionIfGetterIsNotPublic()`
`313`	`313`	`{`
`314`		`- $this->propertyAccessor->setValue(new Author(), 'privateSetter', 'foobar');`
	`314`	`+ $object = new Author();`
	`315`	`+`
	`316`	`+ $this->propertyAccessor->setValue($object, 'privateSetter', 'foobar');`
`315`	`317`	`}`
`316`	`318`
`317`	`319`	`/**`
`@@ -414,7 +416,9 @@ public function getValidPropertyPaths()`
`414`	`416`	`*/`
`415`	`417`	`public function testThrowTypeError()`
`416`	`418`	`{`
`417`		`- $this->propertyAccessor->setValue(new TypeHinted(), 'date', 'This is a string, \DateTime expected.');`
	`419`	`+ $object = new TypeHinted();`
	`420`	`+`
	`421`	`+ $this->propertyAccessor->setValue($object, 'date', 'This is a string, \DateTime expected.');`
`418`	`422`	`}`
`419`	`423`
`420`	`424`	`public function testSetTypeHint()`