Fix BC issue in phpDoc Reflection library

jaapio · jaapio · commit bad07ec557df · 2019-12-28T22:02:19.000+01:00
The used phpDocumentor library DocBlockReflection contained an BC break
that broke this component. The patch was applied in the recent released v4.3.4
version. But since it is unclear how long this issue existed it is not possible
to exclude a certain version. Therefor also `\RuntimeExpception` needs to be catched.

The BC break is possibly caused by a change in the TypeResolver library used by the
DocBlockReflection which is now supporting the more populair generics notation for arrays.
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php
@@ -212,6 +212,8 @@ private function getDocBlockFromProperty($class, $property)
             return $this->docBlockFactory->create($reflectionProperty, $this->contextFactory->createFromReflector($reflectionProperty->getDeclaringClass()));
         } catch (\InvalidArgumentException $e) {
             return null;
+        } catch (\RuntimeException $e) {
+            return null;
         }
     }
 
@@ -257,6 +259,8 @@ private function getDocBlockFromMethod($class, $ucFirstProperty, $type)
             return [$this->docBlockFactory->create($reflectionMethod, $this->contextFactory->createFromReflector($reflectionMethod)), $prefix];
         } catch (\InvalidArgumentException $e) {
             return null;
+        } catch (\RuntimeException $e) {
+            return null;
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,8 @@ private function getDocBlockFromProperty($class, $property)`
`212`	`212`	`return $this->docBlockFactory->create($reflectionProperty, $this->contextFactory->createFromReflector($reflectionProperty->getDeclaringClass()));`
`213`	`213`	`} catch (\InvalidArgumentException $e) {`
`214`	`214`	`return null;`
	`215`	`+ } catch (\RuntimeException $e) {`
	`216`	`+ return null;`
`215`	`217`	`}`
`216`	`218`	`}`
`217`	`219`
`@@ -257,6 +259,8 @@ private function getDocBlockFromMethod($class, $ucFirstProperty, $type)`
`257`	`259`	`return [$this->docBlockFactory->create($reflectionMethod, $this->contextFactory->createFromReflector($reflectionMethod)), $prefix];`
`258`	`260`	`} catch (\InvalidArgumentException $e) {`
`259`	`261`	`return null;`
	`262`	`+ } catch (\RuntimeException $e) {`
	`263`	`+ return null;`
`260`	`264`	`}`
`261`	`265`	`}`
`262`	`266`	`}`