[HttpKernel] added a safeguard for when a fragment is rendered outside the context of a master request

fabpot · fabpot · commit bb83b3ea43f0 · 2013-03-20T17:13:45.000+01:00
diff --git a/src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php b/src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
@@ -93,6 +93,10 @@ public function render($uri, $renderer = 'inline', array $options = array())
             throw new \InvalidArgumentException(sprintf('The "%s" renderer does not exist.', $renderer));
         }
 
+        if (null === $this->request) {
+            throw new \LogicException('Rendering a fragment can only be done when handling a master Request.');
+        }
+
         return $this->deliver($this->renderers[$renderer]->render($uri, $this->request, $options));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,10 @@ public function render($uri, $renderer = 'inline', array $options = array())`
`93`	`93`	`throw new \InvalidArgumentException(sprintf('The "%s" renderer does not exist.', $renderer));`
`94`	`94`	`}`
`95`	`95`
	`96`	`+ if (null === $this->request) {`
	`97`	`+ throw new \LogicException('Rendering a fragment can only be done when handling a master Request.');`
	`98`	`+ }`
	`99`	`+`
`96`	`100`	`return $this->deliver($this->renderers[$renderer]->render($uri, $this->request, $options));`
`97`	`101`	`}`
`98`	`102`