fixup! fixup! [Notifier][SpotHit] Support SMSLong and SMSLongNBr API parameters

camillebaronnet · camillebaronnet · commit bc5e80da829b · 2023-04-25T13:17:44.000+02:00
diff --git a/src/Symfony/Component/Notifier/Bridge/SpotHit/SpotHitTransport.php b/src/Symfony/Component/Notifier/Bridge/SpotHit/SpotHitTransport.php
@@ -54,7 +54,7 @@ public function __toString(): string
             'smslongnbr' => $this->smsLongNBr,
         ]);
 
-        return sprintf('spothit://%s', $this->getEndpoint()) . (!empty($query) ? '?' . $query : '');
+        return sprintf('spothit://%s', $this->getEndpoint()).(!empty($query) ? '?'.$query : '');
     }
 
     public function setSmsLong(?bool $smsLong): self
diff --git a/src/Symfony/Component/Notifier/Bridge/SpotHit/Tests/SpotHitTransportTest.php b/src/Symfony/Component/Notifier/Bridge/SpotHit/Tests/SpotHitTransportTest.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\Notifier\Bridge\SpotHit\Tests;
 
 use Symfony\Component\HttpClient\MockHttpClient;
-use Generator;
 use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Component\Notifier\Bridge\SpotHit\SpotHitTransport;
 use Symfony\Component\Notifier\Message\ChatMessage;
@@ -48,44 +47,44 @@ public static function unsupportedMessagesProvider(): iterable
         yield [new DummyMessage()];
     }
 
-    public function testShouldSendAMessageUsingTheSpotHitAPI(): void
+    public function testShouldSendAMessageUsingTheSpotHitAPI()
     {
         $expectedRequest = [
-            function($method, $url, $options) {
+            function ($method, $url, $options) {
                 $this->assertSame('POST', $method);
                 $this->assertSame('https://www.spot-hit.fr/api/envoyer/sms', $url);
                 $this->assertSame('key=&destinataires=0611223344&type=premium&message=Hello%21&expediteur=', $options['body']);
 
                 return new MockResponse(json_encode([
                     'resultat' => ['success' => 'true'],
                     'id' => '???',
-                ], JSON_THROW_ON_ERROR));
-            }
+                ], \JSON_THROW_ON_ERROR));
+            },
         ];
 
         $client = new MockHttpClient($expectedRequest);
         $transport = new SpotHitTransport('', '', $client, null);
         $transport->send(new SmsMessage('0611223344', 'Hello!'));
     }
 
-    public function argumentsProvider(): Generator
+    public function argumentsProvider(): \Generator
     {
         yield [
-            function(SpotHitTransport $transport) { $transport->setSmsLong(true); },
-            function(array $bodyArguments) { $this->assertSame('1', $bodyArguments['smslong']); },
+            function (SpotHitTransport $transport) { $transport->setSmsLong(true); },
+            function (array $bodyArguments) { $this->assertSame('1', $bodyArguments['smslong']); },
         ];
 
         yield [
-            function(SpotHitTransport $transport) { $transport->setLongNBr(3); },
-            function(array $bodyArguments) { $this->assertSame('3', $bodyArguments['smslongnbr']); },
+            function (SpotHitTransport $transport) { $transport->setLongNBr(3); },
+            function (array $bodyArguments) { $this->assertSame('3', $bodyArguments['smslongnbr']); },
         ];
 
         yield [
-            function(SpotHitTransport $transport) {
+            function (SpotHitTransport $transport) {
                 $transport->setSmsLong(true);
                 $transport->setLongNBr(3);
             },
-            function(array $bodyArguments) {
+            function (array $bodyArguments) {
                 $this->assertSame('1', $bodyArguments['smslong']);
                 $this->assertSame('3', $bodyArguments['smslongnbr']);
             },
@@ -95,19 +94,19 @@ function(array $bodyArguments) {
     /**
      * @dataProvider argumentsProvider
      */
-    public function testShouldForwardArgumentToRequest($setupTransport, $assertions): void
+    public function testShouldForwardArgumentToRequest($setupTransport, $assertions)
     {
         $expectedRequest = [
-            function($method, $url, $options) use ($assertions) {
+            function ($method, $url, $options) use ($assertions) {
                 $bodyFields = [];
                 parse_str($options['body'], $bodyFields);
                 $assertions($bodyFields);
 
                 return new MockResponse(json_encode([
                     'resultat' => ['success' => 'true'],
                     'id' => '???',
-                ], JSON_THROW_ON_ERROR));
-            }
+                ], \JSON_THROW_ON_ERROR));
+            },
         ];
 
         $client = new MockHttpClient($expectedRequest);

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function __toString(): string`
`54`	`54`	`'smslongnbr' => $this->smsLongNBr,`
`55`	`55`	`]);`
`56`	`56`
`57`		`- return sprintf('spothit://%s', $this->getEndpoint()) . (!empty($query) ? '?' . $query : '');`
	`57`	`+ return sprintf('spothit://%s', $this->getEndpoint()).(!empty($query) ? '?'.$query : '');`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`public function setSmsLong(?bool $smsLong): self`