[SecurityBundle] Drop cache.security_expression_language definition if invalid

chalasr · chalasr · commit bc9669333159 · 2020-06-19T21:56:07.000+02:00
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/AddExpressionLanguageProvidersPass.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/AddExpressionLanguageProvidersPass.php
@@ -33,5 +33,9 @@ public function process(ContainerBuilder $container)
                 $definition->addMethodCall('registerProvider', [new Reference($id)]);
             }
         }
+
+        if (!$container->hasDefinition('cache.system')) {
+            $container->removeDefinition('cache.security_expression_language');
+        }
     }
 }
diff --git a/src/Symfony/Bundle/SecurityBundle/Resources/config/security.xml b/src/Symfony/Bundle/SecurityBundle/Resources/config/security.xml
@@ -87,7 +87,7 @@
         <service id="security.user_checker" class="Symfony\Component\Security\Core\User\UserChecker" />
 
         <service id="security.expression_language" class="Symfony\Component\Security\Core\Authorization\ExpressionLanguage">
-            <argument type="service" id="cache.security_expression_language"></argument>
+            <argument type="service" id="cache.security_expression_language" on-invalid="null" />
         </service>
 
         <service id="security.authentication_utils" class="Symfony\Component\Security\Http\Authentication\AuthenticationUtils" public="true">
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/CompleteConfigurationTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/CompleteConfigurationTest.php
@@ -56,7 +56,7 @@ public function testUserProviders()
 
         // chain provider
         $this->assertEquals([new IteratorArgument([
-            new Reference('security.user.provider.concrete.service'),
+            new Reference('user.manager'),
             new Reference('security.user.provider.concrete.basic'),
         ])], $container->getDefinition('security.user.provider.concrete.chain')->getArguments());
     }
@@ -70,9 +70,9 @@ public function testFirewalls()
         foreach (array_keys($arguments[1]->getValues()) as $contextId) {
             $contextDef = $container->getDefinition($contextId);
             $arguments = $contextDef->getArguments();
-            $listeners[] = array_map('strval', $arguments['index_0']->getValues());
+            $listeners[] = array_map('strval', $arguments[0]->getValues());
 
-            $configDef = $container->getDefinition((string) $arguments['index_3']);
+            $configDef = $container->getDefinition((string) $arguments[3]);
             $configs[] = array_values($configDef->getArguments());
         }
 
@@ -87,6 +87,14 @@ public function testFirewalls()
                 'security.user_checker',
                 '.security.request_matcher.xmi9dcw',
                 false,
+                false,
+                '',
+                '',
+                '',
+                '',
+                '',
+                [],
+                null,
             ],
             [
                 'secure',
@@ -657,9 +665,9 @@ public function testSimpleAuth()
         foreach (array_keys($arguments[1]->getValues()) as $contextId) {
             $contextDef = $container->getDefinition($contextId);
             $arguments = $contextDef->getArguments();
-            $listeners[] = array_map('strval', $arguments['index_0']->getValues());
+            $listeners[] = array_map('strval', $arguments[0]->getValues());
 
-            $configDef = $container->getDefinition((string) $arguments['index_3']);
+            $configDef = $container->getDefinition((string) $arguments[3]);
             $configs[] = array_values($configDef->getArguments());
         }
 
@@ -708,6 +716,8 @@ protected function getContainer($file)
 
         $container = new ContainerBuilder();
         $container->setParameter('kernel.debug', false);
+        $container->setParameter('request_listener.http_port', 80);
+        $container->setParameter('request_listener.https_port', 443);
 
         $security = new SecurityExtension();
         $container->registerExtension($security);
@@ -716,7 +726,6 @@ protected function getContainer($file)
         $bundle->build($container); // Attach all default factories
         $this->getLoader($container)->load($file);
 
-        $container->getCompilerPassConfig()->setOptimizationPasses([]);
         $container->getCompilerPassConfig()->setRemovingPasses([]);
         $container->getCompilerPassConfig()->setAfterRemovingPasses([]);
         $container->compile();

Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,9 @@ public function process(ContainerBuilder $container)`
`33`	`33`	`$definition->addMethodCall('registerProvider', [new Reference($id)]);`
`34`	`34`	`}`
`35`	`35`	`}`
	`36`	`+`
	`37`	`+ if (!$container->hasDefinition('cache.system')) {`
	`38`	`+ $container->removeDefinition('cache.security_expression_language');`
	`39`	`+ }`
`36`	`40`	`}`
`37`	`41`	`}`