Fix php string interpolation issue with rename key ending up without {}

andrerom · andrerom · commit be040793acab · 2019-09-22T16:55:30.000+02:00
diff --git a/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php
@@ -195,12 +195,12 @@ private function renameKeys(array $ids): array
         $newIds = [];
         $uniqueToken = bin2hex(random_bytes(10));
         foreach ($ids as $id) {
+            $newId = '{'.$id.'}'.$uniqueToken;
             try {
-                $ok = $this->redis->rename($id, "{$id}$uniqueToken");
-
-                // Only take into account if ok (aka key existed), it will be false on phpredis if it did not exist
+                $ok = $this->redis->rename($id, $newId);
                 if (true === $ok || ($ok instanceof Status && $ok === Status::get('OK'))) {
-                    $newIds[] = "{$id}$uniqueToken";
+                    // Only take into account if ok (key existed), will be false on phpredis if it did not exist
+                    $newIds[] = $newId;
                 }
             } catch (\Predis\Response\ServerException $e) {
                 // Silence errors when key does not exists on Predis. Otherwise re-throw exception
