feature #50879 [Notifier] support local development for sns by adding sslmode option (Ferror)

fabpot · fabpot · commit be8897be228e · 2023-08-01T07:58:51.000+02:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] support local development for sns by adding sslmode option | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes  | Deprecations? | no  | Tickets | none | License | MIT | Doc PR | symfony/symfony-docs#...  When developing locally with AWS -> localstack we have to communicate via HTTP similarly to the SQS Transport for Messenger component. https://github.com/symfony/amazon-sqs-messenger/blob/6.3/Transport/Connection.php#L50C14-L50C14 Commits ------- 92650d6 [Notifier] support local development for sns by adding sslmode option
diff --git a/src/Symfony/Component/Notifier/Bridge/AmazonSns/AmazonSnsTransportFactory.php b/src/Symfony/Component/Notifier/Bridge/AmazonSns/AmazonSnsTransportFactory.php
@@ -31,8 +31,10 @@ public function create(Dsn $dsn): AmazonSnsTransport
 
         $host = 'default' === $dsn->getHost() ? null : $dsn->getHost();
         $port = $dsn->getPort();
+        $sslmode = $dsn->getOption('sslmode', 'enable');
+        $protocol = $sslmode === 'disable' ? 'http' : 'https';
 
-        $options = null === $host ? [] : ['endpoint' => 'https://'.$host.($port ? ':'.$port : '')];
+        $options = null === $host ? [] : ['endpoint' => $protocol.'://'.$host.($port ? ':'.$port : '')];
 
         if ($dsn->getUser()) {
             $options += [
