[VarDumper] Fix FFI caster test

alexandre-daubois · alexandre-daubois · commit bf76480f21d2 · 2024-06-14T13:09:00.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Caster/FFICaster.php b/src/Symfony/Component/VarDumper/Caster/FFICaster.php
@@ -115,12 +115,20 @@ private static function castFFIPointer(Stub $stub, CType $type, ?CData $data = n
     private static function castFFIStringValue(CData $data): string|CutStub
     {
         $result = [];
+        $ffi = \FFI::cdef(<<<C
+            bool is_zend_mm(void);
+            bool is_zend_ptr(const void *ptr);
+        C);
 
         for ($i = 0; $i < self::MAX_STRING_LENGTH; ++$i) {
-            $result[$i] = $data[$i];
+            if ($ffi->is_zend_ptr($data) && $ffi->is_zend_mm()) {
+                $result[$i] = $data[$i];
 
-            if ("\0" === $result[$i]) {
-                return implode('', $result);
+                if ("\0" === $data[$i]) {
+                    return implode('', $result);
+                }
+            } else {
+                break;
             }
         }
 
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/FFICasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/FFICasterTest.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\VarDumper\Tests\Caster;
 
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\VarDumper\Caster\FFICaster;
 use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
 
 /**
@@ -191,25 +190,13 @@ public function testCastCuttedPointerToChar()
         PHP, $pointer);
     }
 
-    /**
-     * It is worth noting that such a test can cause SIGSEGV, as it breaks
-     * into "foreign" memory. However, this is only theoretical, since
-     * memory is allocated within the PHP process and almost always "garbage
-     * data" will be read from the PHP process itself.
-     *
-     * If this test fails for some reason, please report it: We may have to
-     * disable the dumping of strings ("char*") feature in VarDumper.
-     *
-     * @see FFICaster::castFFIStringValue()
-     */
     public function testCastNonTrailingCharPointer()
     {
         $actualMessage = 'Hello World!';
         $actualLength = \strlen($actualMessage);
 
-        $string = \FFI::cdef()->new('char['.$actualLength.']');
+        $string = \FFI::cdef()->new('char['.($actualLength + 1).']');
         $pointer = \FFI::addr($string[0]);
-
         \FFI::memcpy($pointer, $actualMessage, $actualLength);
 
         // Remove automatically addition of the trailing "\0" and remove trailing "\0"
@@ -218,7 +205,7 @@ public function testCastNonTrailingCharPointer()
 
         $this->assertDumpMatchesFormat(<<<PHP
         FFI\CData<char*> size 8 align 8 {
-          cdata: "$actualMessage%s"
+          cdata: %A"$actualMessage%s"
         }
         PHP, $pointer);
     }
