bug #34888 [TwigBundle] add tags before processing them (xabbuh)

xabbuh · xabbuh · commit bf877b811cfe · 2019-12-09T17:39:04.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle] add tags before processing them | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34815 | License | MIT | Doc PR | Commits ------- e1145a7 add tags before processing them
diff --git a/src/Symfony/Bundle/TwigBundle/TwigBundle.php b/src/Symfony/Bundle/TwigBundle/TwigBundle.php
@@ -32,7 +32,8 @@ public function build(ContainerBuilder $container)
     {
         parent::build($container);
 
-        $container->addCompilerPass(new ExtensionPass());
+        // ExtensionPass must be run before the FragmentRendererPass as it adds tags that are processed later
+        $container->addCompilerPass(new ExtensionPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 10);
         $container->addCompilerPass(new TwigEnvironmentPass());
         $container->addCompilerPass(new TwigLoaderPass());
         $container->addCompilerPass(new ExceptionListenerPass());

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ public function build(ContainerBuilder $container)`
`32`	`32`	`{`
`33`	`33`	`parent::build($container);`
`34`	`34`
`35`		`- $container->addCompilerPass(new ExtensionPass());`
	`35`	`+ // ExtensionPass must be run before the FragmentRendererPass as it adds tags that are processed later`
	`36`	`+ $container->addCompilerPass(new ExtensionPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 10);`
`36`	`37`	`$container->addCompilerPass(new TwigEnvironmentPass());`
`37`	`38`	`$container->addCompilerPass(new TwigLoaderPass());`
`38`	`39`	`$container->addCompilerPass(new ExceptionListenerPass());`