Add more tests

fancyweb · fancyweb · commit c00cd1b5b8c2 · 2022-02-09T13:09:08.000+01:00
diff --git a/src/Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php b/src/Symfony/Component/ErrorHandler/Tests/DebugClassLoaderTest.php
@@ -408,13 +408,17 @@ public function testOverrideFinalProperty()
         $e = error_reporting(E_USER_DEPRECATED);
 
         class_exists(Fixtures\OverrideFinalProperty::class, true);
+        class_exists(Fixtures\FinalProperty\OverrideFinalPropertySameNamespace::class, true);
+        class_exists('Test\\'.OverrideOutsideFinalProperty::class, true);
 
         error_reporting($e);
         restore_error_handler();
 
         $this->assertSame([
             'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$pub" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',
             'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$prot" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',
+            'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$implicitlyFinal" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',
+            'The "Test\Symfony\Component\ErrorHandler\Tests\FinalProperty\OutsideFinalProperty::$final" property is considered final. You should not override it in "Test\Symfony\Component\ErrorHandler\Tests\OverrideOutsideFinalProperty".'
         ], $deprecations);
     }
 
@@ -540,6 +544,10 @@ public function ownAbstractBaseMethod() { }
             return $fixtureDir.\DIRECTORY_SEPARATOR.'ReturnType.php';
         } elseif ('Test\\'.Fixtures\OutsideInterface::class === $class) {
             return $fixtureDir.\DIRECTORY_SEPARATOR.'OutsideInterface.php';
+        } elseif ('Test\\'.OverrideOutsideFinalProperty::class === $class) {
+            return $fixtureDir.'OverrideOutsideFinalProperty.php';
+        } elseif ('Test\\Symfony\\Component\\ErrorHandler\\Tests\\FinalProperty\\OutsideFinalProperty' === $class) {
+            return $fixtureDir.'FinalProperty'.\DIRECTORY_SEPARATOR.'OutsideFinalProperty.php';
         }
     }
 }
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/FinalProperty.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/FinalProperty.php
@@ -18,4 +18,15 @@ class FinalProperty
      * @final
      */
     private $priv;
+
+    /**
+     * @final
+     */
+    public $notOverriden;
+
+    protected $implicitlyFinal;
+
+    protected string $typedSoNotFinal;
+
+    protected $deprecated;
 }
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/OutsideFinalProperty.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/OutsideFinalProperty.php
@@ -0,0 +1,23 @@
+<?php
+
+namespace Test\Symfony\Component\ErrorHandler\Tests\FinalProperty;
+
+class OutsideFinalProperty
+{
+    /**
+     * @final
+     */
+    public $final;
+
+    protected $notImplicitlyFinalBecauseNotInSymfony;
+
+    /**
+     * @final
+     */
+    public $notOverriden;
+
+    /**
+     * @final
+     */
+    protected $deprecated;
+}
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/OverrideFinalPropertySameNamespace.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/FinalProperty/OverrideFinalPropertySameNamespace.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty;
+
+class OverrideFinalPropertySameNamespace extends FinalProperty
+{
+    public $pub;
+}
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/OverrideFinalProperty.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/OverrideFinalProperty.php
@@ -9,4 +9,10 @@ class OverrideFinalProperty extends FinalProperty
     public $pub;
     protected $prot;
     private $priv;
+    protected $implicitlyFinal;
+    protected string $typedSoNotFinal;
+    /**
+     * @deprecated
+     */
+    protected $deprecated;
 }
diff --git a/src/Symfony/Component/ErrorHandler/Tests/Fixtures/OverrideOutsideFinalProperty.php b/src/Symfony/Component/ErrorHandler/Tests/Fixtures/OverrideOutsideFinalProperty.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Test\Symfony\Component\ErrorHandler\Tests;
+
+use Test\Symfony\Component\ErrorHandler\Tests\FinalProperty\OutsideFinalProperty;
+
+class OverrideOutsideFinalProperty extends OutsideFinalProperty
+{
+    public $final;
+    protected $notImplicitlyFinalBecauseNotInSymfony;
+    /**
+     * @deprecated
+     */
+    protected $deprecated;
+}

Original file line number	Diff line number	Diff line change
`@@ -408,13 +408,17 @@ public function testOverrideFinalProperty()`
`408`	`408`	`$e = error_reporting(E_USER_DEPRECATED);`
`409`	`409`
`410`	`410`	`class_exists(Fixtures\OverrideFinalProperty::class, true);`
	`411`	`+ class_exists(Fixtures\FinalProperty\OverrideFinalPropertySameNamespace::class, true);`
	`412`	`+ class_exists('Test\\'.OverrideOutsideFinalProperty::class, true);`
`411`	`413`
`412`	`414`	`error_reporting($e);`
`413`	`415`	`restore_error_handler();`
`414`	`416`
`415`	`417`	`$this->assertSame([`
`416`	`418`	`'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$pub" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',`
`417`	`419`	`'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$prot" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',`
	`420`	`+ 'The "Symfony\Component\ErrorHandler\Tests\Fixtures\FinalProperty\FinalProperty::$implicitlyFinal" property is considered final. You should not override it in "Symfony\Component\ErrorHandler\Tests\Fixtures\OverrideFinalProperty".',`
	`421`	`+ 'The "Test\Symfony\Component\ErrorHandler\Tests\FinalProperty\OutsideFinalProperty::$final" property is considered final. You should not override it in "Test\Symfony\Component\ErrorHandler\Tests\OverrideOutsideFinalProperty".'`
`418`	`422`	`], $deprecations);`
`419`	`423`	`}`
`420`	`424`
`@@ -540,6 +544,10 @@ public function ownAbstractBaseMethod() { }`
`540`	`544`	`return $fixtureDir.\DIRECTORY_SEPARATOR.'ReturnType.php';`
`541`	`545`	`} elseif ('Test\\'.Fixtures\OutsideInterface::class === $class) {`
`542`	`546`	`return $fixtureDir.\DIRECTORY_SEPARATOR.'OutsideInterface.php';`
	`547`	`+ } elseif ('Test\\'.OverrideOutsideFinalProperty::class === $class) {`
	`548`	`+ return $fixtureDir.'OverrideOutsideFinalProperty.php';`
	`549`	`+ } elseif ('Test\\Symfony\\Component\\ErrorHandler\\Tests\\FinalProperty\\OutsideFinalProperty' === $class) {`
	`550`	`+ return $fixtureDir.'FinalProperty'.\DIRECTORY_SEPARATOR.'OutsideFinalProperty.php';`
`543`	`551`	`}`
`544`	`552`	`}`
`545`	`553`	`}`