Move dirname() call up

ausi · ausi · commit c2ffd538d574 · 2023-05-30T17:47:54.000+02:00
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -667,14 +667,14 @@ public function dumpFile(string $filename, $content)
             throw new \TypeError(sprintf('Argument 2 passed to "%s()" must be string or resource, array given.', __METHOD__));
         }
 
+        $dir = \dirname($filename);
+
         if (is_link($filename) && $linkTarget = $this->readlink($filename)) {
-            $this->dumpFile(Path::makeAbsolute($linkTarget, \dirname($filename)), $content);
+            $this->dumpFile(Path::makeAbsolute($linkTarget, $dir), $content);
 
             return;
         }
 
-        $dir = \dirname($filename);
-
         if (!is_dir($dir)) {
             $this->mkdir($dir);
         }

Original file line number	Diff line number	Diff line change
`@@ -667,14 +667,14 @@ public function dumpFile(string $filename, $content)`
`667`	`667`	`throw new \TypeError(sprintf('Argument 2 passed to "%s()" must be string or resource, array given.', __METHOD__));`
`668`	`668`	`}`
`669`	`669`
	`670`	`+ $dir = \dirname($filename);`
	`671`	`+`
`670`	`672`	`if (is_link($filename) && $linkTarget = $this->readlink($filename)) {`
`671`		`- $this->dumpFile(Path::makeAbsolute($linkTarget, \dirname($filename)), $content);`
	`673`	`+ $this->dumpFile(Path::makeAbsolute($linkTarget, $dir), $content);`
`672`	`674`
`673`	`675`	`return;`
`674`	`676`	`}`
`675`	`677`
`676`		`- $dir = \dirname($filename);`
`677`		`-`
`678`	`678`	`if (!is_dir($dir)) {`
`679`	`679`	`$this->mkdir($dir);`
`680`	`680`	`}`