[Serializer] Add CDATA_WRAPPING_NAME_PATTERN support to XmlEncoder

Maximilian Ruta · Maximilian Ruta · commit c37ccd5aba9d · 2025-07-24T09:33:46.000+02:00
diff --git a/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php b/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
@@ -443,7 +443,7 @@ private function appendNode(\DOMNode $parentNode, mixed $data, string $format, a
     /**
      * Checks if a value contains any characters which would require CDATA wrapping.
      *
-     * @param array<mixed, mixed> $context
+     * @param array<string, mixed> $context
      */
     private function needsCdataWrapping(string $name, string $val, array $context): bool
     {
diff --git a/src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php b/src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
@@ -581,7 +581,7 @@ public function testCDataNamePattern()
         ]];
 
         $this->assertEquals($expected, $this->encoder->encode($source, 'xml',[
-            XmlEncoder::CDATA_WRAPPING_NAME_PATTERN => '(firstname|lastname|)'
+            XmlEncoder::CDATA_WRAPPING_NAME_PATTERN => '/(firstname|lastname)/'
         ]));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ private function appendNode(\DOMNode $parentNode, mixed $data, string $format, a`
`443`	`443`	`/**`
`444`	`444`	`* Checks if a value contains any characters which would require CDATA wrapping.`
`445`	`445`	`*`
`446`		`- * @param array<mixed, mixed> $context`
	`446`	`+ * @param array<string, mixed> $context`
`447`	`447`	`*/`
`448`	`448`	`private function needsCdataWrapping(string $name, string $val, array $context): bool`
`449`	`449`	`{`
Original file line number	Diff line number	Diff line change
`@@ -581,7 +581,7 @@ public function testCDataNamePattern()`
`581`	`581`	`]];`
`582`	`582`
`583`	`583`	`$this->assertEquals($expected, $this->encoder->encode($source, 'xml',[`
`584`		`- XmlEncoder::CDATA_WRAPPING_NAME_PATTERN => '(firstname\|lastname\|)'`
	`584`	`+ XmlEncoder::CDATA_WRAPPING_NAME_PATTERN => '/(firstname\|lastname)/'`
`585`	`585`	`]));`
`586`	`586`	`}`
`587`	`587`