Skip to content

Commit c87515a

Browse files
committed
fabbot and possible test fixes
1 parent 8e65ea3 commit c87515a

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/Symfony/Bundle/FrameworkBundle/Routing/RouteCollectionBuilder.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ public function addBuilder(RouteCollectionBuilder $builder)
127127
*
128128
* @param RouteCollection $collection
129129
* @param string|null $prefix
130+
*
130131
* @return $this
131132
*/
132133
public function addRouteCollection(RouteCollection $collection, $prefix = null)
@@ -151,6 +152,7 @@ public function addRouteCollection(RouteCollection $collection, $prefix = null)
151152
*
152153
* @param Route $route
153154
* @param string|null $name
155+
*
154156
* @return $this
155157
*/
156158
public function addRoute(Route $route, $name = null)
@@ -361,7 +363,7 @@ public function build()
361363

362364
$routeCollection->add($name, $route);
363365
} else {
364-
/** @var self $route */
366+
/* @var self $route */
365367

366368
$subCollection = $route->build();
367369
$subCollection->addPrefix($this->prefix);

src/Symfony/Bundle/FrameworkBundle/Tests/Routing/RouteCollectionBuilderTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public function testFlushSetsRouteNames()
135135
$collectionBuilder->add('/admin', 'AppBundle:Admin:dashboard', 'admin_dashboard');
136136
// add an unnamed route
137137
$collectionBuilder->add('/blogs', 'AppBundle:Blog:list')
138-
->setMethods('GET');
138+
->setMethods(array('GET'));
139139

140140
// integer route names are allowed - they don't confuse things
141141
$collectionBuilder->add('/products', 'AppBundle:Product:list', 100);
@@ -145,7 +145,7 @@ public function testFlushSetsRouteNames()
145145
$this->assertEquals(array(
146146
'admin_dashboard',
147147
'GET_blogs',
148-
'100'
148+
'100',
149149
), $actualRouteNames);
150150
}
151151

@@ -165,8 +165,8 @@ public function testFlushSetsDetailsOnChildrenRoutes()
165165
->setOption('fooBar', true)
166166
->setHost('example.com')
167167
->setCondition('request.isSecure()')
168-
->setSchemes('https')
169-
->setMethods('POST');
168+
->setSchemes(array('https'))
169+
->setMethods(array('POST'));
170170

171171
// a simple route, nothing added to it
172172
$routes->add('/blogs/{id}', 'editAction', 'blog_edit');
@@ -183,7 +183,7 @@ public function testFlushSetsDetailsOnChildrenRoutes()
183183
->setDefault('_locale', 'fr')
184184
->setRequirement('_locale', 'fr|en')
185185
->setOption('niceRoute', true)
186-
->setSchemes('http')
186+
->setSchemes(array('http'))
187187
->setMethods(array('GET', 'POST'));
188188

189189
$collection = $routes->build();

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy