minor #39721 [Lock] Fix CI (jderusse)

xabbuh · xabbuh · commit c97d85022458 · 2021-01-05T16:44:03.000+01:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [Lock] Fix CI | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- e74a7f2 Fix CI
diff --git a/src/Symfony/Component/Lock/Tests/Store/FlockStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/FlockStoreTest.php
@@ -56,11 +56,10 @@ public function testConstructWhenRepositoryIsNotWriteable()
 
     public function testConstructWithSubdir()
     {
-        if (!getenv('USER') || 'root' === getenv('USER')) {
-            $this->markTestSkipped('This test will fail if run under superuser');
-        }
-
-        new FlockStore(sys_get_temp_dir().'/sf-flock');
+        new FlockStore($dir = (sys_get_temp_dir().'/sf-flock'));
+        $this->assertDirectoryExists($dir);
+        // cleanup
+        @rmdir($dir);
     }
 
     public function testSaveSanitizeName()

Original file line number	Diff line number	Diff line change
`@@ -56,11 +56,10 @@ public function testConstructWhenRepositoryIsNotWriteable()`
`56`	`56`
`57`	`57`	`public function testConstructWithSubdir()`
`58`	`58`	`{`
`59`		`- if (!getenv('USER') \|\| 'root' === getenv('USER')) {`
`60`		`- $this->markTestSkipped('This test will fail if run under superuser');`
`61`		`- }`
`62`		`-`
`63`		`- new FlockStore(sys_get_temp_dir().'/sf-flock');`
	`59`	`+ new FlockStore($dir = (sys_get_temp_dir().'/sf-flock'));`
	`60`	`+ $this->assertDirectoryExists($dir);`
	`61`	`+ // cleanup`
	`62`	`+ @rmdir($dir);`
`64`	`63`	`}`
`65`	`64`
`66`	`65`	`public function testSaveSanitizeName()`